Support multiple disable reasons in ExtensionPerfs

Support multiple disable reasons in ExtensionPerfs

Use a bitmask to represent all the reasons an extension is disabled.
Switch to a new key in ExtensionPrefs for the bitmask.
When we init ExtensionPrefs, check for the old key, migrate the reason over
to the new key, and delete the old key.

BUG=142762
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151785

[Yoyo Zhou, 2012-08-15 00:21:31]

https://chromiumcodereview.appspot.com/10828316/diff/2001/chrome/browser/exte...
File chrome/browser/extensions/extension_prefs.cc (right):

https://chromiumcodereview.appspot.com/10828316/diff/2001/chrome/browser/exte...
chrome/browser/extensions/extension_prefs.cc:726:
Value::CreateIntegerValue(new_value));
This will still store a 0 when there are no disable reasons left. In that case
you should pass NULL to UpdateExtensionPref.

https://chromiumcodereview.appspot.com/10828316/diff/2001/chrome/browser/exte...
chrome/browser/extensions/extension_prefs.cc:930: new_value = 1 << (value - 1);
This is a little opaque. Why not just have a switch statement or if-else chain
over the valid values?

[eaugusti, 2012-08-15 00:48:50]

https://chromiumcodereview.appspot.com/10828316/diff/2001/chrome/browser/exte...
File chrome/browser/extensions/extension_prefs.cc (right):

https://chromiumcodereview.appspot.com/10828316/diff/2001/chrome/browser/exte...
chrome/browser/extensions/extension_prefs.cc:726:
Value::CreateIntegerValue(new_value));
On 2012/08/15 00:21:31, Yoyo Zhou wrote:
> This will still store a 0 when there are no disable reasons left. In that case
> you should pass NULL to UpdateExtensionPref.

Ok. Also changing ClearDisableReasons() update with NULL.

https://chromiumcodereview.appspot.com/10828316/diff/2001/chrome/browser/exte...
chrome/browser/extensions/extension_prefs.cc:930: new_value = 1 << (value - 1);
On 2012/08/15 00:21:31, Yoyo Zhou wrote:
> This is a little opaque. Why not just have a switch statement or if-else chain
> over the valid values?

Done.

[Yoyo Zhou, 2012-08-15 00:58:09]

LGTM

https://chromiumcodereview.appspot.com/10828316/diff/7001/chrome/browser/exte...
File chrome/browser/extensions/extension_prefs.cc (right):

https://chromiumcodereview.appspot.com/10828316/diff/7001/chrome/browser/exte...
chrome/browser/extensions/extension_prefs.cc:725: if (new_value == 0) {
Change 0 to DISABLE_REASON_NONE?

https://chromiumcodereview.appspot.com/10828316/diff/7001/chrome/browser/exte...
chrome/browser/extensions/extension_prefs.cc:930: if (value >
Extension::DEPRECATED_DISABLE_UNKNOWN &&
nit: I would remove this if statement as well as the default case in the switch
statement.

[eaugusti, 2012-08-15 17:36:11]

https://chromiumcodereview.appspot.com/10828316/diff/7001/chrome/browser/exte...
File chrome/browser/extensions/extension_prefs.cc (right):

https://chromiumcodereview.appspot.com/10828316/diff/7001/chrome/browser/exte...
chrome/browser/extensions/extension_prefs.cc:725: if (new_value == 0) {
On 2012/08/15 00:58:09, Yoyo Zhou wrote:
> Change 0 to DISABLE_REASON_NONE?

Done.

https://chromiumcodereview.appspot.com/10828316/diff/7001/chrome/browser/exte...
chrome/browser/extensions/extension_prefs.cc:930: if (value >
Extension::DEPRECATED_DISABLE_UNKNOWN &&
On 2012/08/15 00:58:09, Yoyo Zhou wrote:
> nit: I would remove this if statement as well as the default case in the
switch
> statement.

Done.

[commit-bot: I haz the power, 2012-08-15 17:36:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eaugusti@chromium.org/10828316/8006

[commit-bot: I haz the power, 2012-08-15 18:26:00]

Try job failure for 10828316-8006 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-08-15 20:54:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eaugusti@chromium.org/10828316/8006

[commit-bot: I haz the power, 2012-08-15 23:33:31]

Change committed as 151785