Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 10828314: Move Variations stuff into variations/ directories and add OWNERS files for the variations client t… (Closed)

Created:
8 years, 4 months ago by SteveT
Modified:
8 years, 4 months ago
CC:
chromium-reviews, MAD, jar (doing other things), darin-cc_chromium.org, brettw-cc_chromium.org, James Su, Ilya Sherman
Visibility:
Public.

Description

Move Variations stuff into variations/ directories and add OWNERS files for the variations client team. BUG=None TEST=No user visible changes. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151619

Patch Set 1 : #

Patch Set 2 : mac fix and header fix #

Patch Set 3 : Add OWNERS files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -1819 lines) Patch
M chrome/browser/autocomplete/autocomplete_field_trial.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_field_trials.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/field_trial_synchronizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_log.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_log_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/metrics/variations/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A + chrome/browser/metrics/variations/variations_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/metrics/variations/variations_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/metrics/variations/variations_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/metrics/variations_service.h View 1 chunk +0 lines, -146 lines 0 comments Download
D chrome/browser/metrics/variations_service.cc View 1 chunk +0 lines, -473 lines 0 comments Download
D chrome/browser/metrics/variations_service_unittest.cc View 1 chunk +0 lines, -458 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/child_process_logging_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/metrics/variation_ids.h View 1 chunk +0 lines, -122 lines 0 comments Download
A chrome/common/metrics/variations/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A + chrome/common/metrics/variations/variation_ids.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/common/metrics/variations/variations_util.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/common/metrics/variations/variations_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/common/metrics/variations/variations_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/metrics/variations_util.h View 1 chunk +0 lines, -126 lines 0 comments Download
D chrome/common/metrics/variations_util.cc View 1 chunk +0 lines, -182 lines 0 comments Download
D chrome/common/metrics/variations_util_unittest.cc View 1 chunk +0 lines, -276 lines 0 comments Download
M chrome/renderer/chrome_render_process_observer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
SteveT
Hey Alexei - going through you for an initial review before I pull in OWNERs.
8 years, 4 months ago (2012-08-14 20:15:17 UTC) #1
Alexei Svitkine (slow)
LGTM
8 years, 4 months ago (2012-08-14 20:18:37 UTC) #2
SteveT
OWNERS approval needed from sky@ and isherman@ again. PTAL, guys. Thanks!
8 years, 4 months ago (2012-08-14 20:24:09 UTC) #3
sky
LGTM
8 years, 4 months ago (2012-08-14 22:27:04 UTC) #4
Ilya Sherman
LGTM I didn't see an OWNERS file in the patch set -- did you mean ...
8 years, 4 months ago (2012-08-14 22:43:34 UTC) #5
SteveT
Oh crap, I totally forgot to svn add the OWNERS files. They're up now - ...
8 years, 4 months ago (2012-08-14 23:38:48 UTC) #6
Ilya Sherman
LGTM, thanks
8 years, 4 months ago (2012-08-15 00:24:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevet@chromium.org/10828314/7007
8 years, 4 months ago (2012-08-15 00:50:43 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-15 00:50:55 UTC) #9
Failed to apply patch for
chrome/browser/metrics/variations/variations_service.cc:
While running patch -p0 --forward --force;
patching file chrome/browser/metrics/variations/variations_service.cc
Hunk #1 FAILED at 2.
Hunk #2 FAILED at 17.
2 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/metrics/variations/variations_service.cc.rej

Powered by Google App Engine
This is Rietveld 408576698