Fix improved LoadICs for dictionaries with callbacks.

Fix improved LoadICs for dictionaries with callbacks.

This fixes the positive lookup performed by these LoadICs, to use the
holder instead of the receiver to perfrom the lookup on. It also extends
this improvement to KeyedLoadICs. And it fixes a bug introduced for the
JavaScript getter case of a LoadIC.

R=erik.corry@gmail.com
BUG=chromium:142088
TEST=cctest/test-api/Regress142088,cctest/test-api/Regress137002b

Committed: https://code.google.com/p/v8/source/detail?r=12311

[Erik Corry, 2012-08-14 09:38:35]

LGTM, thanks for fixing.

[Erik Corry, 2012-08-14 11:03:33]

Comment on the ARM version:

https://chromiumcodereview.appspot.com/10828303/diff/2001/src/arm/stub-cache-...
File src/arm/stub-cache-arm.cc (right):

https://chromiumcodereview.appspot.com/10828303/diff/2001/src/arm/stub-cache-...
src/arm/stub-cache-arm.cc:1248: __ push(dictionary);
This is slow on ARM and unnecessary when there are 16 registers.

[Michael Starzinger, 2012-08-14 11:44:05]

https://chromiumcodereview.appspot.com/10828303/diff/2001/src/arm/stub-cache-...
File src/arm/stub-cache-arm.cc (right):

https://chromiumcodereview.appspot.com/10828303/diff/2001/src/arm/stub-cache-...
src/arm/stub-cache-arm.cc:1248: __ push(dictionary);
On 2012/08/14 11:03:33, Erik Corry wrote:
> This is slow on ARM and unnecessary when there are 16 registers.

Done.

[Erik Corry, 2012-08-14 11:59:27]

LGTM