Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: webkit/plugins/npapi/plugin_group_unittest.cc

Issue 10828279: Preprocessing version number for plugins to ignore leading zeros during comparisons. This eliminate… (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/plugins/npapi/plugin_group.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/npapi/plugin_group_unittest.cc
===================================================================
--- webkit/plugins/npapi/plugin_group_unittest.cc (revision 151240)
+++ webkit/plugins/npapi/plugin_group_unittest.cc (working copy)
@@ -27,12 +27,16 @@
{ "10.3 d180", "10.3.180" }, // Flash (Debug)
{ "11.5.7r609", "11.5.7.609"}, // Shockwave
{ "1.6.0_22", "1.6.0.22"}, // Java
+ { "1.07.00_0005", "1.7.0.5"}, // Java with leading zeros
+ { "1..0", "1.0.0" } // Empty version component
};
for (size_t i = 0; i < arraysize(versions); i++) {
Version version;
PluginGroup::CreateVersionFromString(ASCIIToUTF16(versions[i][0]),
&version);
+
+ ASSERT_TRUE(version.IsValid());
EXPECT_EQ(versions[i][1], version.GetString());
}
}
« no previous file with comments | « webkit/plugins/npapi/plugin_group.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698