Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: webkit/plugins/npapi/plugin_group.h

Issue 10828279: Preprocessing version number for plugins to ignore leading zeros during comparisons. This eliminate… (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | webkit/plugins/npapi/plugin_group.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_PLUGINS_NPAPI_PLUGIN_GROUP_H_ 5 #ifndef WEBKIT_PLUGINS_NPAPI_PLUGIN_GROUP_H_
6 #define WEBKIT_PLUGINS_NPAPI_PLUGIN_GROUP_H_ 6 #define WEBKIT_PLUGINS_NPAPI_PLUGIN_GROUP_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 const std::string& identifier); 122 const std::string& identifier);
123 123
124 void InitFrom(const PluginGroup& other); 124 void InitFrom(const PluginGroup& other);
125 125
126 // Returns a non-const vector of all plugins in the group. This is only used 126 // Returns a non-const vector of all plugins in the group. This is only used
127 // by PluginList. 127 // by PluginList.
128 std::vector<webkit::WebPluginInfo>& GetPluginsContainer() { 128 std::vector<webkit::WebPluginInfo>& GetPluginsContainer() {
129 return web_plugin_infos_; 129 return web_plugin_infos_;
130 } 130 }
131 131
132 // Removes leading zeros from each of the components of a version string.
133 // The input version string should be in this format: XXX.YYY.ZZZ...etc.
134 static std::string RemoveLeadingZerosFromVersionComponents(
135 const std::string& version);
136
132 std::string identifier_; 137 std::string identifier_;
133 string16 group_name_; 138 string16 group_name_;
134 string16 name_matcher_; 139 string16 name_matcher_;
135 std::vector<webkit::WebPluginInfo> web_plugin_infos_; 140 std::vector<webkit::WebPluginInfo> web_plugin_infos_;
136 }; 141 };
137 142
138 } // namespace npapi 143 } // namespace npapi
139 } // namespace webkit 144 } // namespace webkit
140 145
141 #endif // WEBKIT_PLUGINS_NPAPI_PLUGIN_GROUP_H_ 146 #endif // WEBKIT_PLUGINS_NPAPI_PLUGIN_GROUP_H_
OLDNEW
« no previous file with comments | « no previous file | webkit/plugins/npapi/plugin_group.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698