Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 10828272: Turn off TLS 1.1. (Closed)

Created:
8 years, 4 months ago by wtc
Modified:
8 years, 4 months ago
Reviewers:
agl, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Turn off TLS 1.1. This change is intended to be merged to the 1180 branch for Chrome 21 Stable. On the trunk this change is only temporary and will be replaced by a fix for bug 141629. R=agl@chromium.org,rsleevi@chromium.org BUG=142172 TEST=Visit https://www.google.com/ and https://www.facebook.com/. Click the lock icon. The page info bubble should say "The connection uses TLS 1.0." Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151198

Patch Set 1 #

Total comments: 1

Patch Set 2 : Allow HTTPSRequestTest.TLSv1Fallback to exit early if TLS 1.1 is disabled #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -16 lines) Patch
M net/base/ssl_config_service.cc View 1 chunk +1 line, -10 lines 0 comments Download
M net/socket/ssl_server_socket_nss.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_server_socket_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_unittest.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
wtc
https://chromiumcodereview.appspot.com/10828272/diff/1/net/socket/ssl_server_socket_nss.cc File net/socket/ssl_server_socket_nss.cc (right): https://chromiumcodereview.appspot.com/10828272/diff/1/net/socket/ssl_server_socket_nss.cc#newcode106 net/socket/ssl_server_socket_nss.cc:106: ssl_config_.version_max = SSL_PROTOCOL_VERSION_TLS1; I don't know why SSLServerSocketNSS overrides ...
8 years, 4 months ago (2012-08-11 20:14:56 UTC) #1
Ryan Sleevi
Might be good to indicate it's only temporary as TLS 1.1 issues are being worked ...
8 years, 4 months ago (2012-08-11 20:44:50 UTC) #2
Ryan Sleevi
lgtm
8 years, 4 months ago (2012-08-11 20:45:24 UTC) #3
wtc
rsleevi: I added that note to the CL's description. Thank you for the suggestion.
8 years, 4 months ago (2012-08-11 20:57:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/10828272/2002
8 years, 4 months ago (2012-08-12 01:09:33 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-12 14:33:39 UTC) #6
Change committed as 151198

Powered by Google App Engine
This is Rietveld 408576698