Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: chrome/browser/sync/glue/bookmark_model_associator.cc

Issue 10828268: [Sync] Fix mobile bookmark folder association on non-android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/profile_sync_service_bookmark_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/glue/bookmark_model_associator.cc
diff --git a/chrome/browser/sync/glue/bookmark_model_associator.cc b/chrome/browser/sync/glue/bookmark_model_associator.cc
index 2b0703359c636665715d9957f2de4a610067a4fd..04fcb6ea724f7b0aed6d99e7df0db0f35f8b05a0 100644
--- a/chrome/browser/sync/glue/bookmark_model_associator.cc
+++ b/chrome/browser/sync/glue/bookmark_model_associator.cc
@@ -397,23 +397,19 @@ syncer::SyncError BookmarkModelAssociator::BuildAssociations() {
// and Other Bookmarks.
error = AssociateTaggedPermanentNode(bookmark_model_->other_node(),
kOtherBookmarksTag);
- if (error.IsSet()) {
+ if (error.IsSet())
return error;
- }
error = AssociateTaggedPermanentNode(bookmark_model_->bookmark_bar_node(),
kBookmarkBarTag);
- if (error.IsSet()) {
+ if (error.IsSet())
return error;
- }
- if (expect_mobile_bookmarks_folder_) {
- error = AssociateTaggedPermanentNode(bookmark_model_->mobile_node(),
- kMobileBookmarksTag);
- if (error.IsSet()) {
- return error;
- }
- }
+ error = AssociateTaggedPermanentNode(bookmark_model_->mobile_node(),
+ kMobileBookmarksTag);
+ if (error.IsSet() && expect_mobile_bookmarks_folder_)
+ return error;
+ error = syncer::SyncError();
int64 bookmark_bar_sync_id = GetSyncIdFromChromeId(
bookmark_model_->bookmark_bar_node()->id());
« no previous file with comments | « no previous file | chrome/browser/sync/profile_sync_service_bookmark_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698