Issue 10828267: Add kSmsTestMessages switch to sms handler unititest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10828267: Add kSmsTestMessages switch to sms handler unititest (Closed)

Created:
8 years, 4 months ago by stevenjb

Modified:
8 years, 4 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add kSmsTestMessages switch to sms handler unititest BUG=141825 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151286

Patch Set 2 : Fix nits. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	chromeos/network/network_sms_handler_unittest.cc	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hashimoto

LGTM with nits http://codereview.chromium.org/10828267/diff/1/chromeos/network/network_sms_handler_unittest.cc File chromeos/network/network_sms_handler_unittest.cc (right): http://codereview.chromium.org/10828267/diff/1/chromeos/network/network_sms_handler_unittest.cc#newcode14 chromeos/network/network_sms_handler_unittest.cc:14: #include "chromeos/chromeos_switches.h" nit: This line should ...

8 years, 4 months ago (2012-08-12 15:00:08 UTC) #2

stevenjb

8 years, 4 months ago (2012-08-13 16:46:45 UTC) #3

http://codereview.chromium.org/10828267/diff/1/chromeos/network/network_sms_h...
File chromeos/network/network_sms_handler_unittest.cc (right):

http://codereview.chromium.org/10828267/diff/1/chromeos/network/network_sms_h...
chromeos/network/network_sms_handler_unittest.cc:14: #include
"chromeos/chromeos_switches.h"
On 2012/08/12 15:00:09, hashimoto wrote:
> nit: This line should come before chromeos/dbus

Done.

http://codereview.chromium.org/10828267/diff/1/chromeos/network/network_sms_h...
chromeos/network/network_sms_handler_unittest.cc:69:
command_line->AppendSwitch(chromeos::switches::kSmsTestMessages);
On 2012/08/12 15:00:09, hashimoto wrote:
> Please add a brief description comment about why this flag is needed.

Done.

Expand Messages | Collapse Messages

Issue 10828267: Add kSmsTestMessages switch to sms handler unititest (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix nits. #

Messages