Issue 10828266: Minor fixes to BubbleBorder2 and LauncherTooltipManager:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10828266: Minor fixes to BubbleBorder2 and LauncherTooltipManager: (Closed)

Created:
8 years, 4 months ago by varunjain

Modified:
8 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, alicet1, sadrul, msw+watch_chromium.org, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Minor fixes to BubbleBorder2 and LauncherTooltipManager: 1. Reset the background of the tooltip frame view or it paints behind the BubbleBorder2 and makes it look blurry. 2. LauncherTooltip bubbles should not consume mouse hovers. 3. BubbleBorder2::GetBorderThickness should return the actual thickness. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151161

Patch Set 1 #

Patch Set 2 : patch #

Patch Set 3 : patch #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
M	ash/launcher/launcher_tooltip_manager.cc	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	ui/views/bubble/bubble_border_2.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/bubble/bubble_delegate.h	View	1 2	2 chunks	+6 lines, -0 lines	0 comments	Download
M	ui/views/bubble/bubble_delegate.cc	View	1	3 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/10828266/6001

8 years, 4 months ago (2012-08-10 22:44:53 UTC) #3

Change committed as 151161

Expand Messages | Collapse Messages