Clean up logging for push_notifications_*.cc

Clean up logging for push_notifications_*.cc

Make Notification::ToString() base64 the data member (since it can hold
binary data).

Convert VLOGs to DVLOGs for push_notifications_*.cc.

BUG=141692
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151367

[akalin, 2012-08-10 20:53:19]

+rlarocque for review
+rvargas fyi

[rlarocque, 2012-08-10 20:58:38]

https://chromiumcodereview.appspot.com/10828264/diff/1/jingle/notifier/listen...
File jingle/notifier/listener/notification_defines.cc (right):

https://chromiumcodereview.appspot.com/10828264/diff/1/jingle/notifier/listen...
jingle/notifier/listener/notification_defines.cc:71:
CHECK(base::Base64Encode(data, &printable_data));
If this is supposed to be semi-human-readable binary data, could we print it in
hex?  I can't learn anything by reading base64.  Hex is a lot easier to read at
a glance.

[akalin, 2012-08-13 20:24:15]

PTAL

http://codereview.chromium.org/10828264/diff/1/jingle/notifier/listener/notif...
File jingle/notifier/listener/notification_defines.cc (right):

http://codereview.chromium.org/10828264/diff/1/jingle/notifier/listener/notif...
jingle/notifier/listener/notification_defines.cc:71:
CHECK(base::Base64Encode(data, &printable_data));
On 2012/08/10 20:58:38, rlarocque wrote:
> If this is supposed to be semi-human-readable binary data, could we print it
in
> hex?  I can't learn anything by reading base64.  Hex is a lot easier to read
at
> a glance.

Done.

[rlarocque, 2012-08-13 20:54:46]

LGTM

[commit-bot: I haz the power, 2012-08-13 20:56:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/10828264/7001

[commit-bot: I haz the power, 2012-08-13 22:06:03]

Change committed as 151367