Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Unified Diff: chrome/browser/ui/toolbar/back_forward_menu_model.cc

Issue 10828263: Moving FaviconService to a ProfileKeyedService. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: resyncing with library after revert Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/back_forward_menu_model.cc
===================================================================
--- chrome/browser/ui/toolbar/back_forward_menu_model.cc (revision 152993)
+++ chrome/browser/ui/toolbar/back_forward_menu_model.cc (working copy)
@@ -10,6 +10,7 @@
#include "base/bind_helpers.h"
#include "base/string_number_conversions.h"
#include "chrome/browser/event_disposition.h"
+#include "chrome/browser/favicon/favicon_service_factory.h"
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
@@ -240,12 +241,12 @@
return;
}
requested_favicons_.insert(entry->GetUniqueID());
- FaviconService* favicon_service =
- browser_->profile()->GetFaviconService(Profile::EXPLICIT_ACCESS);
+ FaviconService* favicon_service = FaviconServiceFactory::GetForProfile(
+ browser_->profile(), Profile::EXPLICIT_ACCESS);
if (!favicon_service)
return;
FaviconService::Handle handle = favicon_service->GetFaviconForURL(
- entry->GetURL(), history::FAVICON, &load_consumer_,
+ browser_->profile(), entry->GetURL(), history::FAVICON, &load_consumer_,
base::Bind(&BackForwardMenuModel::OnFavIconDataAvailable,
base::Unretained(this)));
load_consumer_.SetClientData(favicon_service, handle, entry->GetUniqueID());

Powered by Google App Engine
This is Rietveld 408576698