Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1273)

Unified Diff: chrome/browser/favicon/favicon_service_factory.cc

Issue 10828263: Moving FaviconService to a ProfileKeyedService. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: resyncing with library after revert Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/favicon/favicon_service_factory.h ('k') | chrome/browser/favicon/favicon_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_service_factory.cc
===================================================================
--- chrome/browser/favicon/favicon_service_factory.cc (revision 0)
+++ chrome/browser/favicon/favicon_service_factory.cc (revision 0)
@@ -0,0 +1,55 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/favicon/favicon_service_factory.h"
+
+#include "base/memory/singleton.h"
+#include "chrome/browser/favicon/favicon_service.h"
+#include "chrome/browser/history/history.h"
+#include "chrome/browser/history/history_service_factory.h"
+#include "chrome/browser/prefs/pref_service.h"
+#include "chrome/browser/profiles/profile_dependency_manager.h"
+#include "chrome/common/pref_names.h"
+
+// static
+FaviconService* FaviconServiceFactory::GetForProfile(
+ Profile* profile, Profile::ServiceAccessType sat) {
+ if (!profile->IsOffTheRecord()) {
+ return static_cast<FaviconService*>(
+ GetInstance()->GetServiceForProfile(profile, true));
+ } else if (sat == Profile::EXPLICIT_ACCESS) {
+ // Profile must be OffTheRecord in this case.
+ return static_cast<FaviconService*>(
+ GetInstance()->GetServiceForProfile(
+ profile->GetOriginalProfile(), true));
+ }
+
+ // Profile is OffTheRecord without access.
+ NOTREACHED() << "This profile is OffTheRecord";
+ return NULL;
+}
+
+// static
+FaviconServiceFactory* FaviconServiceFactory::GetInstance() {
+ return Singleton<FaviconServiceFactory>::get();
+}
+
+FaviconServiceFactory::FaviconServiceFactory()
+ : ProfileKeyedServiceFactory("FaviconService",
+ ProfileDependencyManager::GetInstance()) {
+ DependsOn(HistoryServiceFactory::GetInstance());
+}
+
+FaviconServiceFactory::~FaviconServiceFactory() {}
+
+ProfileKeyedService* FaviconServiceFactory::BuildServiceInstanceFor(
+ Profile* profile) const {
+ HistoryService* history_service = HistoryServiceFactory::GetForProfile(
+ profile, Profile::EXPLICIT_ACCESS);
+ return new FaviconService(history_service);
+}
+
+bool FaviconServiceFactory::ServiceIsNULLWhileTesting() {
+ return true;
+}
Property changes on: chrome\browser\favicon\favicon_service_factory.cc
___________________________________________________________________
Added: svn:eol-style
+ LF
« no previous file with comments | « chrome/browser/favicon/favicon_service_factory.h ('k') | chrome/browser/favicon/favicon_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698