Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: chrome/browser/sync/glue/bookmark_change_processor.cc

Issue 10828263: Moving FaviconService to a ProfileKeyedService. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: resyncing with library after revert Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/glue/bookmark_change_processor.h" 5 #include "chrome/browser/sync/glue/bookmark_change_processor.h"
6 6
7 #include <stack> 7 #include <stack>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/location.h" 10 #include "base/location.h"
11 #include "base/string16.h" 11 #include "base/string16.h"
12 #include "base/string_util.h" 12 #include "base/string_util.h"
13 #include "base/utf_string_conversions.h" 13 #include "base/utf_string_conversions.h"
14 #include "chrome/browser/bookmarks/bookmark_model.h" 14 #include "chrome/browser/bookmarks/bookmark_model.h"
15 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 15 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
16 #include "chrome/browser/bookmarks/bookmark_utils.h" 16 #include "chrome/browser/bookmarks/bookmark_utils.h"
17 #include "chrome/browser/favicon/favicon_service.h" 17 #include "chrome/browser/favicon/favicon_service.h"
18 #include "chrome/browser/favicon/favicon_service_factory.h"
18 #include "chrome/browser/history/history_service_factory.h" 19 #include "chrome/browser/history/history_service_factory.h"
19 #include "chrome/browser/profiles/profile.h" 20 #include "chrome/browser/profiles/profile.h"
20 #include "chrome/browser/sync/profile_sync_service.h" 21 #include "chrome/browser/sync/profile_sync_service.h"
21 #include "content/public/browser/browser_thread.h" 22 #include "content/public/browser/browser_thread.h"
22 #include "sync/internal_api/public/change_record.h" 23 #include "sync/internal_api/public/change_record.h"
23 #include "sync/internal_api/public/read_node.h" 24 #include "sync/internal_api/public/read_node.h"
24 #include "sync/internal_api/public/write_node.h" 25 #include "sync/internal_api/public/write_node.h"
25 #include "sync/internal_api/public/write_transaction.h" 26 #include "sync/internal_api/public/write_transaction.h"
26 #include "sync/syncable/entry.h" // TODO(tim): Investigating bug 121587. 27 #include "sync/syncable/entry.h" // TODO(tim): Investigating bug 121587.
27 #include "ui/gfx/image/image_util.h" 28 #include "ui/gfx/image/image_util.h"
(...skipping 602 matching lines...) Expand 10 before | Expand all | Expand 10 after
630 // Registering a favicon requires that we provide a source URL, but we 631 // Registering a favicon requires that we provide a source URL, but we
631 // don't know where these came from. Currently we just use the 632 // don't know where these came from. Currently we just use the
632 // destination URL, which is not correct, but since the favicon URL 633 // destination URL, which is not correct, but since the favicon URL
633 // is used as a key in the history's thumbnail DB, this gives us a value 634 // is used as a key in the history's thumbnail DB, this gives us a value
634 // which does not collide with others. 635 // which does not collide with others.
635 GURL fake_icon_url = bookmark_node->url(); 636 GURL fake_icon_url = bookmark_node->url();
636 637
637 HistoryService* history = 638 HistoryService* history =
638 HistoryServiceFactory::GetForProfile(profile, Profile::EXPLICIT_ACCESS); 639 HistoryServiceFactory::GetForProfile(profile, Profile::EXPLICIT_ACCESS);
639 FaviconService* favicon_service = 640 FaviconService* favicon_service =
640 profile->GetFaviconService(Profile::EXPLICIT_ACCESS); 641 FaviconServiceFactory::GetForProfile(profile, Profile::EXPLICIT_ACCESS);
641 642
642 history->AddPageNoVisitForBookmark(bookmark_node->url(), 643 history->AddPageNoVisitForBookmark(bookmark_node->url(),
643 bookmark_node->GetTitle()); 644 bookmark_node->GetTitle());
644 favicon_service->SetFavicon(bookmark_node->url(), 645 favicon_service->SetFavicon(bookmark_node->url(),
645 fake_icon_url, 646 fake_icon_url,
646 icon_bytes_vector, 647 icon_bytes_vector,
647 history::FAVICON); 648 history::FAVICON);
648 } 649 }
649 650
650 // static 651 // static
651 void BookmarkChangeProcessor::SetSyncNodeFavicon( 652 void BookmarkChangeProcessor::SetSyncNodeFavicon(
652 const BookmarkNode* bookmark_node, 653 const BookmarkNode* bookmark_node,
653 BookmarkModel* model, 654 BookmarkModel* model,
654 syncer::WriteNode* sync_node) { 655 syncer::WriteNode* sync_node) {
655 std::vector<unsigned char> favicon_bytes; 656 std::vector<unsigned char> favicon_bytes;
656 EncodeFavicon(bookmark_node, model, &favicon_bytes); 657 EncodeFavicon(bookmark_node, model, &favicon_bytes);
657 if (!favicon_bytes.empty()) 658 if (!favicon_bytes.empty())
658 sync_node->SetFaviconBytes(favicon_bytes); 659 sync_node->SetFaviconBytes(favicon_bytes);
659 } 660 }
660 661
661 } // namespace browser_sync 662 } // namespace browser_sync
OLDNEW
« no previous file with comments | « chrome/browser/profiles/profile_impl.cc ('k') | chrome/browser/sync/glue/session_model_associator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698