Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1803)

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 10828260: Small bug fix in comparison of usage_counter for x64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_x64.cc
===================================================================
--- runtime/vm/intermediate_language_x64.cc (revision 10509)
+++ runtime/vm/intermediate_language_x64.cc (working copy)
@@ -59,6 +59,7 @@
Register temp = locs()->temp(0).reg();
ASSERT(result == RAX);
if (!compiler->is_optimizing()) {
+ __ Comment("Check function counter");
// Count only in unoptimized code.
// TODO(srdjan): Replace the counting code with a type feedback
// collection and counting stub.
@@ -68,7 +69,7 @@
__ incq(FieldAddress(temp, Function::usage_counter_offset()));
if (FlowGraphCompiler::CanOptimize()) {
// Do not optimize if usage count must be reported.
- __ cmpl(FieldAddress(temp, Function::usage_counter_offset()),
+ __ cmpq(FieldAddress(temp, Function::usage_counter_offset()),
Immediate(FLAG_optimization_counter_threshold));
Label not_yet_hot, already_optimized;
__ j(LESS, &not_yet_hot, Assembler::kNearJump);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698