Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 10828259: Move AutofillExternalDelegateGtk to chrome/browser/ui/gtk/autofill, where it belongs. (Closed)

Created:
8 years, 4 months ago by Jói
Modified:
8 years, 4 months ago
CC:
chromium-reviews, dhollowa+watch_chromium.org, Ilya Sherman, browser-components-watch_chromium.org, dyu1
Visibility:
Public.

Description

Move AutofillExternalDelegateGtk to chrome/browser/ui/gtk/autofill, where it belongs. The class implementation is all to do with UI, and has dependencies on GTK UI code, so this seems a more appropriate home for it. Moving it to its rightful home also removes a couple of unwanted includes from chrome/browser/autofill/DEPS. TBR=ben@chromium.org BUG=140037 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151467

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Merge to head #

Patch Set 4 : Merge to head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -163 lines) Patch
M chrome/browser/autofill/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/autofill/autofill_external_delegate_gtk.h View 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/autofill/autofill_external_delegate_gtk.cc View 1 chunk +0 lines, -92 lines 0 comments Download
A + chrome/browser/ui/gtk/autofill/autofill_external_delegate_gtk.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/gtk/autofill/autofill_external_delegate_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Jói
erikwright: Main reviewer. erg: chrome/browser/ui/gtk OWNERS. csharp: FYI since we were discussing this. Cheers, Jói
8 years, 4 months ago (2012-08-10 16:00:52 UTC) #1
Elliot Glaysher
gtk lgtm
8 years, 4 months ago (2012-08-10 16:38:26 UTC) #2
Jói
Erik, waiting for your LGTM as main reviewer. On Fri, Aug 10, 2012 at 4:38 ...
8 years, 4 months ago (2012-08-13 19:58:37 UTC) #3
erikwright (departed)
LGTM.
8 years, 4 months ago (2012-08-13 20:02:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/10828259/5003
8 years, 4 months ago (2012-08-13 21:12:16 UTC) #5
commit-bot: I haz the power
Presubmit check for 10828259-5003 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-13 21:12:22 UTC) #6
Jói
TBRing for chrome/OWNERS since the change there is just a trivial gypi change. On Mon, ...
8 years, 4 months ago (2012-08-13 21:13:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/10828259/5003
8 years, 4 months ago (2012-08-13 21:13:36 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-13 22:16:37 UTC) #9
Try job failure for 10828259-5003 (retry) on mac_rel for step "check_deps".
It's a second try, previously, step "check_deps" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698