Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: chrome/browser/debugger/devtools_sanity_browsertest.cc

Issue 10828254: Mark DevToolsSanityTest.TestScriptsTabIsPopulatedOnInspectedPageRefresh flaky on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/cancelable_callback.h" 6 #include "base/cancelable_callback.h"
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
(...skipping 402 matching lines...) Expand 10 before | Expand all | Expand 10 after
413 413
414 414
415 // Tests scripts panel showing. 415 // Tests scripts panel showing.
416 IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, TestShowScriptsTab) { 416 IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, TestShowScriptsTab) {
417 RunTest("testShowScriptsTab", kDebuggerTestPage); 417 RunTest("testShowScriptsTab", kDebuggerTestPage);
418 } 418 }
419 419
420 // Tests that scripts tab is populated with inspected scripts even if it 420 // Tests that scripts tab is populated with inspected scripts even if it
421 // hadn't been shown by the moment inspected paged refreshed. 421 // hadn't been shown by the moment inspected paged refreshed.
422 // @see http://crbug.com/26312 422 // @see http://crbug.com/26312
423 #if defined(OS_WIN)
424 // http://crbug.com/141849
425 #define MAYBE_TestScriptsTabIsPopulatedOnInspectedPageRefresh \
426 FLAKY_TestScriptsTabIsPopulatedOnInspectedPageRefresh
427 #else
428 #define MAYBE_TestScriptsTabIsPopulatedOnInspectedPageRefresh \
429 TestScriptsTabIsPopulatedOnInspectedPageRefresh
430 #endif
423 IN_PROC_BROWSER_TEST_F( 431 IN_PROC_BROWSER_TEST_F(
424 DevToolsSanityTest, 432 DevToolsSanityTest,
425 TestScriptsTabIsPopulatedOnInspectedPageRefresh) { 433 MAYBE_TestScriptsTabIsPopulatedOnInspectedPageRefresh) {
426 // Clear inspector settings to ensure that Elements will be 434 // Clear inspector settings to ensure that Elements will be
427 // current panel when DevTools window is open. 435 // current panel when DevTools window is open.
428 content::GetContentClient()->browser()->ClearInspectorSettings( 436 content::GetContentClient()->browser()->ClearInspectorSettings(
429 GetInspectedTab()->GetRenderViewHost()); 437 GetInspectedTab()->GetRenderViewHost());
430 RunTest("testScriptsTabIsPopulatedOnInspectedPageRefresh", 438 RunTest("testScriptsTabIsPopulatedOnInspectedPageRefresh",
431 kDebuggerTestPage); 439 kDebuggerTestPage);
432 } 440 }
433 441
434 // Tests that chrome.devtools extension is correctly exposed. 442 // Tests that chrome.devtools extension is correctly exposed.
435 IN_PROC_BROWSER_TEST_F(DevToolsExtensionTest, 443 IN_PROC_BROWSER_TEST_F(DevToolsExtensionTest,
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
603 content::CONSOLE_MESSAGE_LEVEL_LOG, 611 content::CONSOLE_MESSAGE_LEVEL_LOG,
604 "log"); 612 "log");
605 devtools_manager->AddMessageToConsole(agent_host, 613 devtools_manager->AddMessageToConsole(agent_host,
606 content::CONSOLE_MESSAGE_LEVEL_ERROR, 614 content::CONSOLE_MESSAGE_LEVEL_ERROR,
607 "error"); 615 "error");
608 RunTestFunction(window_, "checkLogAndErrorMessages"); 616 RunTestFunction(window_, "checkLogAndErrorMessages");
609 CloseDevToolsWindow(); 617 CloseDevToolsWindow();
610 } 618 }
611 619
612 } // namespace 620 } // namespace
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698