Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 10828253: Fix intermittent failure in ReleaseOverReservedPages on x64. (Closed)

Created:
8 years, 4 months ago by Erik Corry
Modified:
8 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Fix intermittent failure in ReleaseOverReservedPages on x64. BUG=v8:2216 Committed: https://code.google.com/p/v8/source/detail?r=12292

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M src/mark-compact.cc View 1 2 chunks +14 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Erik Corry
8 years, 4 months ago (2012-08-10 12:37:41 UTC) #1
Michael Starzinger
https://chromiumcodereview.appspot.com/10828253/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): https://chromiumcodereview.appspot.com/10828253/diff/1/src/mark-compact.cc#newcode635 src/mark-compact.cc:635: (reduce_memory_footprint_ && over_reserved >= space->AreaSize())) { Can we merge ...
8 years, 4 months ago (2012-08-10 13:03:14 UTC) #2
Erik Corry
8 years, 4 months ago (2012-08-10 13:41:26 UTC) #3
Michael Starzinger
8 years, 4 months ago (2012-08-10 13:57:00 UTC) #4
LGTM (on the version that was commited, not the last patch set).

Powered by Google App Engine
This is Rietveld 408576698