gdata: Rename AddEntryToDirectory() to MoveEntryFromRootDirectory()

gdata: Rename AddEntryToDirectory() to MoveEntryFromRootDirectory()

The original name was a misnomer. Looking at the code, the function
moves an entry from the root directory to another directory.

Along the way, remove if (!callback.is_null()) and PostTask() from
this and related functions.

BUG=126634, 139446
TEST=copying and moving of files on Drive work as before

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150907

[satorux1, 2012-08-09 21:22:54]

I was trying to eliminate FindEntryByPathSync() from  AddEntryToDirectory(), and
realized that the function name was a misnomer.

[achuithb, 2012-08-09 21:32:42]

lgtm.

https://chromiumcodereview.appspot.com/10828238/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/gdata/gdata_file_system.h (right):

https://chromiumcodereview.appspot.com/10828238/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_file_system.h:429: // root directory to
another directory.
Maybe also state that this calls
GDataDirectoryService::MoveEntryFromRootDirectory. 

I find our comments for callbacks usually say that this is some callback for a
function. This information is actually easily inferred from the function name.
We often fail to describe what the callback actually does.

[satorux1, 2012-08-09 21:50:54]

https://chromiumcodereview.appspot.com/10828238/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/gdata/gdata_file_system.h (right):

https://chromiumcodereview.appspot.com/10828238/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_file_system.h:429: // root directory to
another directory.
On 2012/08/09 21:32:42, achuith.bhandarkar wrote:
> Maybe also state that this calls
> GDataDirectoryService::MoveEntryFromRootDirectory. 

You meant  GDataDirectoryService::MoveEntryToDirectory(), right?

> 
> I find our comments for callbacks usually say that this is some callback for a
> function. This information is actually easily inferred from the function name.
> We often fail to describe what the callback actually does.

Agreed. added some comment.

[achuithb, 2012-08-09 22:42:34]

https://chromiumcodereview.appspot.com/10828238/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/gdata/gdata_file_system.h (right):

https://chromiumcodereview.appspot.com/10828238/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_file_system.h:429: // root directory to
another directory.
On 2012/08/09 21:50:54, satorux1 wrote:
> On 2012/08/09 21:32:42, achuith.bhandarkar wrote:
> > Maybe also state that this calls
> > GDataDirectoryService::MoveEntryFromRootDirectory. 
> 
> You meant  GDataDirectoryService::MoveEntryToDirectory(), right?

Yup, sorry.

> > 
> > I find our comments for callbacks usually say that this is some callback for
a
> > function. This information is actually easily inferred from the function
name.
> > We often fail to describe what the callback actually does.
> 
> Agreed. added some comment.