crbug.com/121235 - Renderer crash on middle-click on Linux Desktop.

crbug.com/121235 - Renderer crash on middle-click on Linux Desktop.

Fix: Add handling the case when both USE_X11 and USE_AURA are defined.

BUG=121235
TEST=Click middle mouse button in tab window on Linux Desktop; no crash


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151130

[brettw, 2012-08-09 19:06:11]

http://codereview.chromium.org/10828233/diff/1/webkit/glue/webclipboard_impl.cc
File webkit/glue/webclipboard_impl.cc (right):

http://codereview.chromium.org/10828233/diff/1/webkit/glue/webclipboard_impl....
webkit/glue/webclipboard_impl.cc:265: return false;
I don't really understand your comment. What does "on" mean and what does
"doesn't use X selection" mean for this code path?

[sschmitz, 2012-08-09 20:35:23]

Removed unclear comment

[brettw, 2012-08-09 20:44:07]

Well, now I'm confused about what the code means? Can you come up with something
that explains why Aura doesn't support this format?

[sschmitz, 2012-08-10 16:13:30]

On 2012/08/09 20:44:07, brettw wrote:
> Well, now I'm confused about what the code means? Can you come up with
something
> that explains why Aura doesn't support this format?
I asked oshima@ and he says:
Selection is the special type of clipboard that only X window system supports.
See the comment in

http://code.google.com/searchframe#OAMlx_jo-ck/src/ui/base/clipboard/clipboar...

and we explicitly disable this feature because we (UX team) do not like this
behavior.

[brettw, 2012-08-10 19:24:31]

Can we put something to that effect in the code? "Aura only supports the
standard clipboard, not the X selection one."

[oshima, 2012-08-10 19:47:08]

drive by

http://codereview.chromium.org/10828233/diff/5001/webkit/glue/webclipboard_im...
File webkit/glue/webclipboard_impl.cc (right):

http://codereview.chromium.org/10828233/diff/5001/webkit/glue/webclipboard_im...
webkit/glue/webclipboard_impl.cc:262: #if defined(USE_AURA)
this should be USE_ASH , or OS_CHROMEOS

Linux aura should support X selection

[sschmitz, 2012-08-10 20:09:20]

On 2012/08/10 19:47:08, oshima wrote:
> drive by
> 
>
http://codereview.chromium.org/10828233/diff/5001/webkit/glue/webclipboard_im...
> File webkit/glue/webclipboard_impl.cc (right):
> 
>
http://codereview.chromium.org/10828233/diff/5001/webkit/glue/webclipboard_im...
> webkit/glue/webclipboard_impl.cc:262: #if defined(USE_AURA)
> this should be USE_ASH , or OS_CHROMEOS
> 
> Linux aura should support X selection

Thanks Oshima (again) for your drive-by from Japan! I will change it to
OS_CHROMEOS.

[sschmitz, 2012-08-10 20:18:27]

http://codereview.chromium.org/10828233/diff/1/webkit/glue/webclipboard_impl.cc
File webkit/glue/webclipboard_impl.cc (right):

http://codereview.chromium.org/10828233/diff/1/webkit/glue/webclipboard_impl....
webkit/glue/webclipboard_impl.cc:265: return false;
On 2012/08/09 19:06:11, brettw wrote:
> I don't really understand your comment. What does "on" mean and what does
> "doesn't use X selection" mean for this code path?
Comment replaced by better one (thanks to Oshima)

http://codereview.chromium.org/10828233/diff/5001/webkit/glue/webclipboard_im...
File webkit/glue/webclipboard_impl.cc (right):

http://codereview.chromium.org/10828233/diff/5001/webkit/glue/webclipboard_im...
webkit/glue/webclipboard_impl.cc:262: #if defined(USE_AURA)
On 2012/08/10 19:47:08, oshima wrote:
> this should be USE_ASH , or OS_CHROMEOS
> 
> Linux aura should support X selection
Changed USE_AURA to OS_CHROMEOS
Done.

[brettw, 2012-08-10 20:19:53]

lgtm

[commit-bot: I haz the power, 2012-08-10 20:21:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sschmitz@chromium.org/10828233/5002

[commit-bot: I haz the power, 2012-08-10 21:56:47]

Change committed as 151130