Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 10828227: Force eager compilation of some function literals. (Closed)

Created:
8 years, 4 months ago by Michael Starzinger
Modified:
8 years, 4 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Force eager compilation of some function literals. In case a function literal is followed by parenthesis, we consider this a hint that it will be called immediately. If we happen to have parsed that function literal eagerly, we can also compile it eagerly. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12320

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Ulan Degenbaev. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M src/ast.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/parser.cc View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
8 years, 4 months ago (2012-08-09 11:01:23 UTC) #1
ulan
LGTM https://chromiumcodereview.appspot.com/10828227/diff/1/src/ast.h File src/ast.h (right): https://chromiumcodereview.appspot.com/10828227/diff/1/src/ast.h#newcode2094 src/ast.h:2094: bool is_parenthesized() { Maybe add a comment describing ...
8 years, 4 months ago (2012-08-16 10:20:03 UTC) #2
Michael Starzinger
8 years, 4 months ago (2012-08-16 11:19:21 UTC) #3
Addressed comments. Landing ...

https://chromiumcodereview.appspot.com/10828227/diff/1/src/ast.h
File src/ast.h (right):

https://chromiumcodereview.appspot.com/10828227/diff/1/src/ast.h#newcode2094
src/ast.h:2094: bool is_parenthesized() {
On 2012/08/16 10:20:03, ulan wrote:
> Maybe add a comment describing the cases when this holds?

Done.

Powered by Google App Engine
This is Rietveld 408576698