Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6831)

Unified Diff: chrome/browser/ui/panels/panel_browsertest.cc

Issue 10828220: Fix Linux panels to return to minimized mode after mouse moves away. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update DragMinimizedPanelWhileDrawingAttention Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_browsertest.cc
diff --git a/chrome/browser/ui/panels/panel_browsertest.cc b/chrome/browser/ui/panels/panel_browsertest.cc
index 13b677ddc93afa3dd7329cf1bf01ff4340b9cc76..33459e9669a2915e00d93fdce22ece651cd2b689 100644
--- a/chrome/browser/ui/panels/panel_browsertest.cc
+++ b/chrome/browser/ui/panels/panel_browsertest.cc
@@ -1164,7 +1164,14 @@ IN_PROC_BROWSER_TEST_F(PanelBrowserTest, StopDrawingAttentionWhileMinimized) {
EXPECT_EQ(Panel::TITLE_ONLY, panel1->expansion_state());
EXPECT_EQ(Panel::MINIMIZED, panel2->expansion_state());
- // Move mouse away and panel should go back to fully minimized state.
+ // Typical user scenario will detect the mouse in the panel
+ // after attention is cleared, causing titles to pop up, so
+ // we simulate that here.
+ MoveMouseAndWaitForExpansionStateChange(panel2, hover_point_in_panel);
+ EXPECT_EQ(Panel::TITLE_ONLY, panel1->expansion_state());
+ EXPECT_EQ(Panel::TITLE_ONLY, panel2->expansion_state());
+
+ // Move mouse away and panels should go back to fully minimized state.
MoveMouseAndWaitForExpansionStateChange(panel1, hover_point);
EXPECT_EQ(Panel::MINIMIZED, panel1->expansion_state());
EXPECT_EQ(Panel::MINIMIZED, panel2->expansion_state());
« no previous file with comments | « chrome/browser/ui/panels/old_panel_drag_browsertest.cc ('k') | chrome/browser/ui/panels/panel_drag_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698