Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 10828220: Fix Linux panels to return to minimized mode after mouse moves away. (Closed)

Created:
8 years, 4 months ago by jennb
Modified:
8 years, 4 months ago
Reviewers:
jianli
CC:
chromium-reviews, jennb, jianli, Dmitry Titov, dcheng
Visibility:
Public.

Description

Fix Linux panels to return to fully minimized mode after mouse moves away. Regression came from change to leave panel in title-only mode when draw attention is cleared, but mouse is over the panel title. (r137530) BUG=None TEST=Updated StopDrawingAttentionWhileMinimized and DragMinimizedPanelWhileDrawingAttention Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151190

Patch Set 1 : #

Patch Set 2 : update DragMinimizedPanelWhileDrawingAttention #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M chrome/browser/ui/panels/docked_panel_strip.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/old_panel_browsertest.cc View 1 chunk +8 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/old_panel_drag_browsertest.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 1 chunk +8 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_drag_browsertest.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jennb
The panels were staying in hover mode because we keep posting a new task to ...
8 years, 4 months ago (2012-08-09 00:32:46 UTC) #1
jennb
Jian - pinging to make sure you saw this patch, too.
8 years, 4 months ago (2012-08-10 03:46:56 UTC) #2
jianli
lgtm
8 years, 4 months ago (2012-08-10 16:53:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennb@chromium.org/10828220/7002
8 years, 4 months ago (2012-08-10 17:48:27 UTC) #4
commit-bot: I haz the power
Try job failure for 10828220-7002 (retry) on linux_clang for step "update" (clobber build). It's a ...
8 years, 4 months ago (2012-08-10 18:27:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennb@chromium.org/10828220/7002
8 years, 4 months ago (2012-08-11 03:44:02 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-12 01:56:54 UTC) #7
Change committed as 151190

Powered by Google App Engine
This is Rietveld 408576698