Issue 10828217: string_util support for joining strings using strings not just chars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10828217: string_util support for joining strings using strings not just chars. (Closed)

Created:
8 years, 4 months ago by Steve McKay

Modified:
8 years, 3 months ago

Reviewers:
brettw

CC:
chromium-reviews, erikwright (departed), jshin+watch_chromium.org, brettw-cc_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Add support for joining strings on strings rather than just chars. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153568

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -4 lines)			Patch
M	base/string_util.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	base/string_util.cc	View	2 chunks	+13 lines, -4 lines	0 comments	Download
M	base/string_util_unittest.cc	View	1 chunk	+38 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Steve McKay

Needed by http://codereview.chromium.org/10824212/ to join web intent actions for inclusion in settings editor.

8 years, 4 months ago (2012-08-08 23:47:56 UTC) #1

Steve McKay

Correction. Needed by CL http://codereview.chromium.org/10808092/

8 years, 4 months ago (2012-08-08 23:49:57 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/smckay@chromium.org/10828217/5001

8 years, 3 months ago (2012-08-27 18:22:42 UTC) #4

Change committed as 153568