Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10828203: Reverting r148671, r149866 (broke VS2008 builder) and r150361 (broke ninja). (Closed)

Created:
8 years, 4 months ago by alexeypa (please no reviews)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, pam+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Reverting r148671, r149866 (broke VS2008 builder) and r150361 (broke ninja). Rolling GYP to r1458 to undo (r1457, r1452, r1450, r1449). BUG=141132, 137755 TBR=alexeypa@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150494

Patch Set 1 #

Patch Set 2 : GYP changes were reverted at 1459. #

Patch Set 3 : Let's try GYP r1446. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -76 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/plugin/daemon_controller_win.cc View 3 chunks +3 lines, -19 lines 0 comments Download
M remoting/host/win/chromoting.wxs View 5 chunks +6 lines, -14 lines 0 comments Download
M remoting/host/win/elevated_controller.h View 2 chunks +3 lines, -4 lines 0 comments Download
M remoting/host/win/elevated_controller.idl View 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting.gyp View 4 chunks +0 lines, -11 lines 0 comments Download
M remoting/tools/candle_and_light.py View 2 chunks +0 lines, -2 lines 0 comments Download
D remoting/tools/uuidgen.py View 1 chunk +0 lines, -18 lines 0 comments Download
M skia/skia.gyp View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
alexeypa (please no reviews)
Please take a look. I'm undoing all my recent changes in Chromium and GYP.
8 years, 4 months ago (2012-08-08 00:49:49 UTC) #1
scottmg
On 2012/08/08 00:49:49, alexeypa wrote: > Please take a look. > > I'm undoing all ...
8 years, 4 months ago (2012-08-08 02:13:20 UTC) #2
scottmg
On 2012/08/08 02:13:20, scottmg wrote: > We'll have to I don't know what this was. ...
8 years, 4 months ago (2012-08-08 02:14:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10828203/5002
8 years, 4 months ago (2012-08-08 02:53:53 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-08 04:25:09 UTC) #5 
Change committed as 150494

Powered by Google App Engine
This is Rietveld 408576698