Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10828198: Update oauth strings for extension install UI (Closed)

Created:
8 years, 4 months ago by Evan Stade
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, tfarina, sail
Visibility:
Public.

Description

Update oauth strings for extension install UI BUG=130206 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151755

Patch Set 1 #

Patch Set 2 : fix unit tests #

Total comments: 2

Patch Set 3 : string descriptions #

Patch Set 4 : fix compile #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -18 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 1 2 3 7 chunks +22 lines, -6 lines 0 comments Download
M chrome/browser/extensions/webstore_inline_installer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_unittest.mm View 1 2 6 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view.cc View 1 2 1 chunk +3 lines, -2 lines 1 comment Download

Messages

Total messages: 10 (0 generated)
Evan Stade
8 years, 4 months ago (2012-08-07 20:23:04 UTC) #1
Evan Stade
ping (I will soon get around to fixing the build failures)
8 years, 4 months ago (2012-08-09 23:13:37 UTC) #2
sail
cocoa/* LGTM
8 years, 4 months ago (2012-08-10 17:36:14 UTC) #3
Mihai Parparita -not on Chrome
http://codereview.chromium.org/10828198/diff/6002/chrome/browser/extensions/extension_install_prompt.cc File chrome/browser/extensions/extension_install_prompt.cc (right): http://codereview.chromium.org/10828198/diff/6002/chrome/browser/extensions/extension_install_prompt.cc#newcode178 chrome/browser/extensions/extension_install_prompt.cc:178: username = UTF8ToUTF16(profile_->GetPrefs()->GetString( Isn't it possible for the user ...
8 years, 4 months ago (2012-08-11 00:13:23 UTC) #4
Evan Stade
http://codereview.chromium.org/10828198/diff/6002/chrome/browser/extensions/extension_install_prompt.cc File chrome/browser/extensions/extension_install_prompt.cc (right): http://codereview.chromium.org/10828198/diff/6002/chrome/browser/extensions/extension_install_prompt.cc#newcode178 chrome/browser/extensions/extension_install_prompt.cc:178: username = UTF8ToUTF16(profile_->GetPrefs()->GetString( On 2012/08/11 00:13:24, Mihai Parparita wrote: ...
8 years, 4 months ago (2012-08-11 00:25:44 UTC) #5
Munjal (Google)
LGTM
8 years, 4 months ago (2012-08-13 17:44:25 UTC) #6
Evan Stade
+Mihai for extensions/ OWNER review. +Peter for views/ OWNER review.
8 years, 4 months ago (2012-08-14 21:24:25 UTC) #7
Mihai Parparita -not on Chrome
LGTM
8 years, 4 months ago (2012-08-14 22:58:33 UTC) #8
Evan Stade
views/ TBR=pkasting.
8 years, 4 months ago (2012-08-15 21:40:13 UTC) #9
Peter Kasting
8 years, 4 months ago (2012-08-15 21:41:48 UTC) #10 
LGTM

http://codereview.chromium.org/10828198/diff/7004/chrome/browser/ui/views/ext...
File chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
(right):

http://codereview.chromium.org/10828198/diff/7004/chrome/browser/ui/views/ext...
chrome/browser/ui/views/extensions/extension_install_dialog_view.cc:244:
prompt.GetPermissionCount() + prompt.GetOAuthIssueCount() > 0 ?
Nit: I suggest parens around addition

Powered by Google App Engine
This is Rietveld 408576698