Revert 148511 - Add pin icon to the omnibar in windows 8 metro mode.

Revert 148511 - Add pin icon to the omnibar in windows 8 metro mode.

The pin icon allows pinning and unpinning the start screen. The icon used changes depending on whether the page is currently pinned or not.

BUG=129598
TEST=Test pages can be pinned and unpinned from metro mode


Review URL: https://chromiumcodereview.appspot.com/10800054

TBR=sky@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150229

[tfarina, 2012-08-07 02:10:56]

On Mon, Aug 6, 2012 at 11:01 PM,  <benwells@chromium.org> wrote:
> Reviewers: benwells,
>
> Description:
> Revert 148511 - Add pin icon to the omnibar in windows 8 metro mode.
>
> The pin icon allows pinning and unpinning the start screen. The icon used
> changes depending on whether the page is currently pinned or not.
>
Please, include the reason why you are reverting the (a) patch in
commit message.

This always strikes me. This is not personally to you. People usually
revert a patch, but does not give any reason for doing it. Which is
bad, because in future no one will remember why it had to be reverted.
Not that will matter much, but I think is always good to know why
something happened in our code base.

-- 
Thiago

[benwells1, 2012-08-07 02:12:06]

OK, apologies, there is another patch being reverted related to this, I'll
explain there.

Thanks for the tip.


On Tue, Aug 7, 2012 at 12:10 PM, Thiago Farina <tfarina@chromium.org> wrote:

> On Mon, Aug 6, 2012 at 11:01 PM,  <benwells@chromium.org> wrote:
> > Reviewers: benwells,
> >
> > Description:
> > Revert 148511 - Add pin icon to the omnibar in windows 8 metro mode.
> >
> > The pin icon allows pinning and unpinning the start screen. The icon used
> > changes depending on whether the page is currently pinned or not.
> >
> Please, include the reason why you are reverting the (a) patch in
> commit message.
>
> This always strikes me. This is not personally to you. People usually
> revert a patch, but does not give any reason for doing it. Which is
> bad, because in future no one will remember why it had to be reverted.
> Not that will matter much, but I think is always good to know why
> something happened in our code base.
>
> --
> Thiago
>