Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 10828187: [NaCl SDK] Support multiple configs (Closed)

Created:
8 years, 4 months ago by binji
Modified:
8 years, 4 months ago
Reviewers:
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

[NaCl SDK] Support multiple configs Slightly modified from noelallen's codereview.chromium.org/10823177. My changes: style nits, as well as fixing pnacl builds original CL description follows: This CL adds support for Debug and Release configs. It moves functions that require knowledge of the Makefile to make_rules.py and keeps functions that require understanding of the DSC files in generate_make.py. It adds a 'config' parameter to the embed in common.js. Updates all index.html files to support the new config parameter. make_rules.py has been converted to a class. This allows the object to persist state about the build which allows us to remove knowledge of the make rules from generate_make.py. BUG=none TBR=noelallen@chromium.org NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+421 lines, -325 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 chunk +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/build_tools/generate_make.py View 10 chunks +97 lines, -147 lines 0 comments Download
M native_client_sdk/src/build_tools/make_rules.py View 7 chunks +295 lines, -153 lines 0 comments Download
M native_client_sdk/src/build_tools/redirect.html View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/examples/common.js View 3 chunks +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/examples/debugging/index.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/dlopen/index.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/file_histogram/index.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/file_io/index.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/fullscreen_tumbler/index.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/gamepad/index.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/geturl/index.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/hello_world/index.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/hello_world_gles/index.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/hello_world_interactive/index.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/input_events/index.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/load_progress/index.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/mouselock/index.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/multithreaded_input_events/index.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/pi_generator/index.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/pong/index.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/sine_synth/index.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/tumbler/index.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/websocket/index.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/10828187/1
8 years, 4 months ago (2012-08-07 06:46:04 UTC) #1
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 06:46:21 UTC) #2
Change committed as 150289

Powered by Google App Engine
This is Rietveld 408576698