Issue 10828184: ash: Update launcher overflow chevron.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10828184: ash: Update launcher overflow chevron. (Closed)

Created:
8 years, 4 months ago by xiyuan

Modified:
8 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, oshima+watch_chromium.org, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Update launcher overflow chevron. - Use new overflow chevron assets; - Code drawing hover/pressed state and rotate image for left/right launcher; BUG=132855 TEST=Verify launcher chevron uses new image and has hover effect similar to app menu and ubertray. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150272

Patch Set 1 #

Patch Set 2 : fix clang #

Patch Set 3 : fix launcher_view_test_api compile #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+169 lines, -16 lines)			Patch
M	ash/ash.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ash/launcher/launcher_view.h	View		3 chunks	+2 lines, -2 lines	0 comments	Download
M	ash/launcher/launcher_view.cc	View		4 chunks	+3 lines, -16 lines	0 comments	Download
A	ash/launcher/overflow_button.h	View		1 chunk	+43 lines, -0 lines	0 comments	Download
A	ash/launcher/overflow_button.cc	View	1	1 chunk	+122 lines, -0 lines	0 comments	Download
M	ash/test/launcher_view_test_api.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/resources/default_100_percent/ash/launcher_overflow.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	ui/resources/default_100_percent/ash/launcher_overflow_hover.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	ui/resources/default_100_percent/ash/launcher_overflow_pressed.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	ui/resources/default_200_percent/ash/launcher_overflow.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	ui/resources/ui_resources.grd	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages