[Chromoting] Moving common logic responsible for launching child processes to WorkerProcessLauncher…

remoting/host/win/launch_process_with_token.h

Index: remoting/host/win/launch_process_with_token.h
diff --git a/remoting/host/win/launch_process_with_token.h b/remoting/host/win/launch_process_with_token.h
index 54479d5a56391460453cb655deacdac15a10f417..c250c541769e812e2270d163ffc322f016eb9067 100644
--- a/remoting/host/win/launch_process_with_token.h
+++ b/remoting/host/win/launch_process_with_token.h
@@ -22,8 +22,8 @@ bool CreateSessionToken(uint32 session_id, base::win::ScopedHandle* token_out);
 // |user_token|. The session ID specified by the token is respected as well.
 bool LaunchProcessWithToken(const FilePath& binary,
                             const std::wstring& command_line,
-                            HANDLE user_token,
-                            base::Process* process_out);
+                            const base::win::ScopedHandle& user_token,

[Wez, 2012/08/08 20:13:41]

This forces the caller to wrap the user token in a ScopedHandle, requiring that
they "own" it - why not stick with a bare HANDLE?

[alexeypa (please no reviews), 2012/08/08 21:49:58]

Well, the intent is to emphasize that the caller owns the handle.

[Wez, 2012/08/10 00:09:23]

But actually all you want to express is that this function doesn't take
ownership of the handle; the caller may pass a handle that some other code owns,
and which it therefore can't wrap into a ScopedHandle.

[alexeypa (please no reviews), 2012/08/10 16:18:44]

OK, it makes sense.

+                            base::win::ScopedHandle* process_out);
 
 } // namespace remoting