Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 10828177: Refactors FileSystemQuotaClient using base::Callback. (Closed)

Created:
8 years, 4 months ago by nhiroki
Modified:
8 years, 4 months ago
Reviewers:
kinuko
CC:
chromium-reviews, kinuko+watch, darin-cc_chromium.org, tzik
Visibility:
Public.

Description

Refactors FileSystemQuotaClient using base::Callback. BUG=139270 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150290

Patch Set 1 #

Total comments: 2

Patch Set 2 : Unwraps make_scoped_refptr for file_system_context. #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -230 lines) Patch
M webkit/fileapi/file_system_quota_client.h View 3 chunks +1 line, -37 lines 0 comments Download
M webkit/fileapi/file_system_quota_client.cc View 1 2 3 6 chunks +92 lines, -193 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
nhiroki
Hi kinuko@ Could you review this? Thanks.
8 years, 4 months ago (2012-08-06 18:47:08 UTC) #1
kinuko
lgtm https://chromiumcodereview.appspot.com/10828177/diff/1/webkit/fileapi/file_system_quota_client.cc File webkit/fileapi/file_system_quota_client.cc (right): https://chromiumcodereview.appspot.com/10828177/diff/1/webkit/fileapi/file_system_quota_client.cc#newcode190 webkit/fileapi/file_system_quota_client.cc:190: make_scoped_refptr(file_system_context_.get()), nit: maybe you can just pass file_system_context_ ...
8 years, 4 months ago (2012-08-06 21:06:27 UTC) #2
nhiroki
Thank you for reviewing! https://chromiumcodereview.appspot.com/10828177/diff/1/webkit/fileapi/file_system_quota_client.cc File webkit/fileapi/file_system_quota_client.cc (right): https://chromiumcodereview.appspot.com/10828177/diff/1/webkit/fileapi/file_system_quota_client.cc#newcode190 webkit/fileapi/file_system_quota_client.cc:190: make_scoped_refptr(file_system_context_.get()), On 2012/08/06 21:06:27, kinuko ...
8 years, 4 months ago (2012-08-06 21:30:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/10828177/8001
8 years, 4 months ago (2012-08-07 01:17:36 UTC) #4
commit-bot: I haz the power
Failed to apply patch for webkit/fileapi/file_system_quota_client.cc: While running patch -p1 --forward --force; patching file webkit/fileapi/file_system_quota_client.cc ...
8 years, 4 months ago (2012-08-07 03:59:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/10828177/4005
8 years, 4 months ago (2012-08-07 05:39:32 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 06:49:25 UTC) #7
Change committed as 150290

Powered by Google App Engine
This is Rietveld 408576698