Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 10828175: Removes some code that is currently not necessary and causes problems (Closed)

Created:
8 years, 4 months ago by sky
Modified:
8 years, 4 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Removes some code that is currently not necessary and causes problems for tab dragging code. The StackAtTop() is unnecessary with current code and appears to cause a capture lost during tab dragging which leads to a crash. BUG=140606 TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150144

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/ui/views/location_bar/location_bar_container_win.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
8 years, 4 months ago (2012-08-06 13:59:12 UTC) #1
Ben Goodger (Google)
8 years, 4 months ago (2012-08-06 19:37:43 UTC) #2
lgtm


On Mon, Aug 6, 2012 at 6:59 AM, <sky@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Removes some code that is currently not necessary and causes problems
> for tab dragging code. The StackAtTop() is unnecessary with current
> code and appears to cause a capture lost during tab dragging which
> leads to a crash.
>
> BUG=140606
> TEST=none
> R=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/10828175/<http://codereview.chromium.org/108...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M chrome/browser/ui/views/**location_bar/location_bar_**container_win.cc
>
>
> Index: chrome/browser/ui/views/**location_bar/location_bar_**
> container_win.cc
> diff --git
a/chrome/browser/ui/views/**location_bar/location_bar_**container_win.cc
> b/chrome/browser/ui/views/**location_bar/location_bar_**container_win.cc
> index 78a04ef4319e732a76500230fcb30d**169a7412f7..**
> 6d7f3101ee498226f627ff85a22d08**760bfa7d90 100644
> --- a/chrome/browser/ui/views/**location_bar/location_bar_**
> container_win.cc
> +++ b/chrome/browser/ui/views/**location_bar/location_bar_**
> container_win.cc
> @@ -54,5 +54,8 @@ SkColor LocationBarContainer::**GetBackgroundColor() {
>  }
>
>  void LocationBarContainer::**StackAtTop() {
> +  // TODO: reenable when PlatformInit() code is reenabled.
> +  /*
>    view_parent_->GetWidget()->**StackAtTop();
> +  */
>  }
>
>
>

Powered by Google App Engine
This is Rietveld 408576698