Issue 10828168: bookmarks: Fix mistakes found by cppcheck.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10828168: bookmarks: Fix mistakes found by cppcheck. (Closed)

Created:
8 years, 4 months ago by tfarina

Modified:
8 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

bookmarks: Fix mistakes found by cppcheck. bookmark_index_unittest.cc: Summary: Function parameter 'expected_titles' should be passed by reference. Message: Parameter 'expected_titles' is passed as a value. It could be passed as a (const) reference which is usually faster and recommended in C++. bookmark_model_unittest.cc: Summary: Member variable 'BookmarkModelTestWithProfile::bb_model_' is not initialized in the constructor. Message: Member variable 'BookmarkModelTestWithProfile::bb_model_' is not initialized in the constructor. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150346

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/bookmarks/bookmark_index_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/bookmarks/bookmark_model_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages