Issue 10828163: gdata: Remove obsolete GDataDB related code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10828163: gdata: Remove obsolete GDataDB related code (Closed)

Created:
8 years, 4 months ago by satorux1

Modified:
8 years, 4 months ago

Reviewers:
achuithb

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: Remove obsolete GDataDB related code Turned out the original design was not good, and the code won't be used. BUG=140314 TEST=compile TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149955

Patch Set 1 #

Patch Set 2 : remove FromProtoString too #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -801 lines)			Patch
D	chrome/browser/chromeos/gdata/gdata_db.h	View		1 chunk	+0 lines, -73 lines	0 comments	Download
D	chrome/browser/chromeos/gdata/gdata_db_factory.h	View		1 chunk	+0 lines, -24 lines	0 comments	Download
D	chrome/browser/chromeos/gdata/gdata_db_factory.cc	View		1 chunk	+0 lines, -22 lines	0 comments	Download
D	chrome/browser/chromeos/gdata/gdata_db_unittest.cc	View		1 chunk	+0 lines, -349 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_files.h	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_files.cc	View	1	1 chunk	+0 lines, -27 lines	0 comments	Download
D	chrome/browser/chromeos/gdata/gdata_leveldb.h	View		1 chunk	+0 lines, -61 lines	0 comments	Download
D	chrome/browser/chromeos/gdata/gdata_leveldb.cc	View		1 chunk	+0 lines, -235 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

achuithb

lgtm. Please don't close the bug yet - there are now orphaned functions in gdata_files.h ...

8 years, 4 months ago (2012-08-03 21:43:00 UTC) #2

satorux1

8 years, 4 months ago (2012-08-03 22:41:22 UTC) #5

TBR=ben@chromium.org for .gypi changes. (just removing files)

Expand Messages | Collapse Messages