Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: chrome/browser/sync/profile_sync_service.h

Issue 10828158: [Sync] Address msw's comments for r149747 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_ 5 #ifndef CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_
6 #define CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_ 6 #define CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_
7 7
8 #include <list> 8 #include <list>
9 #include <string> 9 #include <string>
10 10
(...skipping 533 matching lines...) Expand 10 before | Expand all | Expand 10 after
544 return configure_status_; 544 return configure_status_;
545 } 545 }
546 546
547 // If true, the ProfileSyncService has detected that a new GAIA signin has 547 // If true, the ProfileSyncService has detected that a new GAIA signin has
548 // succeeded, and is waiting for initialization to complete. This is used by 548 // succeeded, and is waiting for initialization to complete. This is used by
549 // the UI to differentiate between a new auth error (encountered as part of 549 // the UI to differentiate between a new auth error (encountered as part of
550 // the initialization process) and a pre-existing auth error that just hasn't 550 // the initialization process) and a pre-existing auth error that just hasn't
551 // been cleared yet. Virtual for testing purposes. 551 // been cleared yet. Virtual for testing purposes.
552 virtual bool waiting_for_auth() const; 552 virtual bool waiting_for_auth() const;
553 553
554 // Updates the set of ObjectIds associated with a given 554 // Updates the set of ObjectIds associated with a given |handler|.
akalin 2012/08/03 20:08:49 Done.
555 // |handler|. Passing an empty ObjectIdSet will unregister 555 // Passing an empty ObjectIdSet will unregister |handler|. There
msw 2012/08/03 22:57:16 nit: Line break after |handler|.
akalin 2012/08/04 00:02:05 Done.
556 // |handler|. There should be at most one handler registered per 556 // should be at most one handler registered per object id.
557 // object id.
558 // 557 //
559 // The handler -> registered ids map is persisted across restarts of 558 // The handler -> registered ids map is persisted across restarts of
560 // sync. 559 // sync.
561 void UpdateRegisteredInvalidationIds(syncer::SyncNotifierObserver* handler, 560 void UpdateRegisteredInvalidationIds(syncer::SyncNotifierObserver* handler,
562 const syncer::ObjectIdSet& ids); 561 const syncer::ObjectIdSet& ids);
563 562
564 // ProfileKeyedService implementation. 563 // ProfileKeyedService implementation.
565 virtual void Shutdown() OVERRIDE; 564 virtual void Shutdown() OVERRIDE;
566 565
567 protected: 566 protected:
(...skipping 274 matching lines...) Expand 10 before | Expand all | Expand 10 after
842 syncer::SyncNotifierHelper notifier_helper_; 841 syncer::SyncNotifierHelper notifier_helper_;
843 842
844 DISALLOW_COPY_AND_ASSIGN(ProfileSyncService); 843 DISALLOW_COPY_AND_ASSIGN(ProfileSyncService);
845 }; 844 };
846 845
847 bool ShouldShowActionOnUI( 846 bool ShouldShowActionOnUI(
848 const syncer::SyncProtocolError& error); 847 const syncer::SyncProtocolError& error);
849 848
850 849
851 #endif // CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_ 850 #endif // CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698