Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10828153: Change butter bar message depending on the type of operation and the number of files. (Closed)

Created:
8 years, 4 months ago by Oleg Eterevsky
Modified:
8 years, 4 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Change butter bar message depending on the type of operation and the number of files. BUG=134601 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149865

Patch Set 1 #

Patch Set 2 : Fix move to GData. #

Total comments: 4

Patch Set 3 : Remove debug output. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -67 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +42 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 1 chunk +17 lines, -5 lines 0 comments Download
M chrome/browser/resources/file_manager/js/butter_bar.js View 1 2 5 chunks +42 lines, -17 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_copy_manager.js View 1 2 chunks +28 lines, -19 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_copy_manager_wrapper.js View 2 chunks +6 lines, -15 lines 0 comments Download
M chrome/browser/resources/file_manager/js/mock_chrome.js View 1 chunk +17 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Oleg Eterevsky
8 years, 4 months ago (2012-08-03 13:56:12 UTC) #1
Vladislav Kaznacheev
https://chromiumcodereview.appspot.com/10828153/diff/3001/chrome/browser/resources/file_manager/js/butter_bar.js File chrome/browser/resources/file_manager/js/butter_bar.js (right): https://chromiumcodereview.appspot.com/10828153/diff/3001/chrome/browser/resources/file_manager/js/butter_bar.js#newcode213 chrome/browser/resources/file_manager/js/butter_bar.js:213: console.log(this.progress_.pendingItems); You probably did not mean to leave this? ...
8 years, 4 months ago (2012-08-03 14:50:10 UTC) #2
Oleg Eterevsky
https://chromiumcodereview.appspot.com/10828153/diff/3001/chrome/browser/resources/file_manager/js/butter_bar.js File chrome/browser/resources/file_manager/js/butter_bar.js (right): https://chromiumcodereview.appspot.com/10828153/diff/3001/chrome/browser/resources/file_manager/js/butter_bar.js#newcode213 chrome/browser/resources/file_manager/js/butter_bar.js:213: console.log(this.progress_.pendingItems); On 2012/08/03 14:50:10, Vladislav Kaznacheev wrote: > You ...
8 years, 4 months ago (2012-08-03 14:53:00 UTC) #3
Vladislav Kaznacheev
lgtm
8 years, 4 months ago (2012-08-03 15:44:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oleg@chromium.org/10828153/6004
8 years, 4 months ago (2012-08-03 15:44:52 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-03 17:19:15 UTC) #6 
Change committed as 149865

Powered by Google App Engine
This is Rietveld 408576698