chrome: Copy app_list files from views/ to ash/

chrome: Copy app_list files from views/ to ash/

BUG=125846
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150053

[tfarina, 2012-08-03 13:34:07]

http://codereview.chromium.org/10828151/diff/5001/chrome/browser/ui/DEPS
File chrome/browser/ui/DEPS (right):

http://codereview.chromium.org/10828151/diff/5001/chrome/browser/ui/DEPS#newc...
chrome/browser/ui/DEPS:7:
"!chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.h",
next, I'll move ash/launcher.

The only dependency in launcher on chrome/browser/ui/views/ is browser_view.h

 BrowserView* browser_view = static_cast<BrowserView*>(browser->window());    
 BrowserLauncherItemController* launcher_item_controller =                    
     browser_view->launcher_item_controller();

in chrome/browser/ui/views/ash/launcher/launcher_favicon_loader_browsertest.cc

[tfarina, 2012-08-03 13:37:29]

On 2012/08/03 13:34:07, tfarina wrote:
> The only dependency in launcher on chrome/browser/ui/views/ is browser_view.h
> 
>  BrowserView* browser_view = static_cast<BrowserView*>(browser->window());    
>  BrowserLauncherItemController* launcher_item_controller =                    
>      browser_view->launcher_item_controller();
> 
> in chrome/browser/ui/views/ash/launcher/launcher_favicon_loader_browsertest.cc

By the way, we have other dependencies in BrowserView in browser_focus_uitest.cc
and ui_test_utils_aura/win.cc

[tfarina, 2012-08-03 13:42:50]

http://codereview.chromium.org/10828151/diff/5001/chrome/browser/ui/views/ash...
File chrome/browser/ui/views/ash/chrome_shell_delegate.cc (right):

http://codereview.chromium.org/10828151/diff/5001/chrome/browser/ui/views/ash...
chrome/browser/ui/views/ash/chrome_shell_delegate.cc:22: #include
"chrome/browser/ui/views/ash/user_action_handler.h"
these two can also be moved to ui/ash. They do not include any file from
chrome/browser/ui/views/

[Ben Goodger (Google), 2012-08-03 17:13:05]

On 2012/08/03 13:37:29, tfarina wrote:
> By the way, we have other dependencies in BrowserView in
browser_focus_uitest.cc
> and ui_test_utils_aura/win.cc

re browser_focus_uitest:
- platform neutral abstractions should be made, if there are multi-platform
ifdefs or,
- if a test is views-specific, that test should move to a new browsertest file
in browser/ui/views.

As for ui_test_utils.. we will eventually have to refactor chrome/test to fix
its dependency on views. perhaps we need chrome/browser/ui/test and
corresponding chrome/browser/ui/views/test, chrome/browser/ui/gtk/test etc.

[Ben Goodger (Google), 2012-08-03 17:13:16]

lgtm

[tfarina, 2012-08-05 17:17:36]

On 2012/08/03 17:13:16, Ben Goodger (Google) wrote:
> lgtm

Ben, I'm going to just copy the files for now, as windows is not liking the git
mv. :/

So I'm doing "cp from to" and "git add target" to work around this and in a
follow up I'll remove the old files and update the new ones.

[Ben Goodger (Google), 2012-08-06 19:28:12]

OK

On 2012/08/05 17:17:36, tfarina wrote:
> On 2012/08/03 17:13:16, Ben Goodger (Google) wrote:
> > lgtm
> 
> Ben, I'm going to just copy the files for now, as windows is not liking the
git
> mv. :/
> 
> So I'm doing "cp from to" and "git add target" to work around this and in a
> follow up I'll remove the old files and update the new ones.

[tfarina, 2012-08-19 17:12:40]

On Fri, Aug 3, 2012 at 2:13 PM,  <ben@chromium.org> wrote:
> As for ui_test_utils.. we will eventually have to refactor chrome/test to
> fix
> its dependency on views. perhaps we need chrome/browser/ui/test and
> corresponding chrome/browser/ui/views/test, chrome/browser/ui/gtk/test etc.
>
Yes, that will be good.

Unfortunately too many files outside of chrome/browser/ui/ includes
chrome/test/base/ui_test_utils.h.

The thing I'm planning to do next is to move
chrome/test/base/ui_test_utils_aura.cc and
chrome/test/base/ui_test_utils_win.cc into
chrome/browser/ui/views/test/, chrome/test/base/ui_test_utils_gtk.cc
into chrome/browser/ui/gtk/test/ and
chrome/test/base/ui_test_utils_mac.mm into
chrome/browser/ui/cocoa/test/.

That way I can get rid of the dependency in browser_view.h from two more
places!

-- 
Thiago