Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 10828146: Fixed compound/count operations with getter-only accessor properties. (Closed)

Created:
8 years, 4 months ago by Sven Panne
Modified:
8 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fixed compound/count operations with getter-only accessor properties. The underlying problem is that for compound/count operations we use the *load* type feedback for storing, too. For normal properties this doesn't matter, but for accessor properties we should better use the *store* type feedback, which would be available, too. This consistent feedback usage could be guaranteed if we removed the heavy copy-n-paste in the crankshaft code generation for compound/count operations and assignments/property loads. To be on the safe side, we postpone this refactoring and do a quick and easily mergeable fix. BUG=140083 TEST=mjsunit/regress/regress-crbug-140083.js Committed: https://code.google.com/p/v8/source/detail?r=12252

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
M src/hydrogen.cc View 2 chunks +6 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-140083.js View 1 chunk +11 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
8 years, 4 months ago (2012-08-03 08:55:33 UTC) #1
Michael Starzinger
8 years, 4 months ago (2012-08-03 09:44:31 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698