Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 10828135: Allow popups, mouselock, and https media-stream content by default. (Closed)

Created:
8 years, 4 months ago by kkania
Modified:
8 years, 4 months ago
Reviewers:
dennis_jeffrey
CC:
chromium-reviews, kkania
Visibility:
Public.

Description

Allow popups, mouselock and https media-stream content by default. Add a simple HTTPS server for testing getUserMedia. Popups used to be allowed through --disable-popup-blocking, but this has a bug where the resulting popup cannot be resized smaller. Instead, allow popups by modifying the prefs. BUG=chromedriver:118, chromedriver:126 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150214

Patch Set 1 : . #

Total comments: 6

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -46 lines) Patch
A + chrome/test/webdriver/test/cert.pem View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/webdriver/test/chromedriver_test.py View 1 3 chunks +63 lines, -4 lines 0 comments Download
M chrome/test/webdriver/test/chromedriver_tests.py View 1 2 3 chunks +48 lines, -13 lines 0 comments Download
D chrome/test/webdriver/test/content_setting_test.html View 1 chunk +0 lines, -21 lines 0 comments Download
A + chrome/test/webdriver/test/empty.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/webdriver/test/test_paths.py View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/webdriver/webdriver_automation.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/webdriver/webdriver_automation.cc View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M chrome/test/webdriver/webdriver_session.cc View 1 2 2 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kkania
8 years, 4 months ago (2012-08-02 21:50:48 UTC) #1
dennis_jeffrey
2 nits and a question http://codereview.chromium.org/10828135/diff/2001/chrome/test/webdriver/test/chromedriver_test.py File chrome/test/webdriver/test/chromedriver_test.py (right): http://codereview.chromium.org/10828135/diff/2001/chrome/test/webdriver/test/chromedriver_test.py#newcode26 chrome/test/webdriver/test/chromedriver_test.py:26: data = file(path, 'r').read() ...
8 years, 4 months ago (2012-08-03 18:10:42 UTC) #2
kkania
http://codereview.chromium.org/10828135/diff/2001/chrome/test/webdriver/test/chromedriver_test.py File chrome/test/webdriver/test/chromedriver_test.py (right): http://codereview.chromium.org/10828135/diff/2001/chrome/test/webdriver/test/chromedriver_test.py#newcode26 chrome/test/webdriver/test/chromedriver_test.py:26: data = file(path, 'r').read() On 2012/08/03 18:10:42, dennis_jeffrey wrote: ...
8 years, 4 months ago (2012-08-06 21:50:27 UTC) #3
dennis_jeffrey
LGTM
8 years, 4 months ago (2012-08-06 22:20:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/10828135/2002
8 years, 4 months ago (2012-08-06 22:42:40 UTC) #5
commit-bot: I haz the power
Failed to apply patch for chrome/test/webdriver/test/chromedriver_tests.py: While running patch -p1 --forward --force; patching file chrome/test/webdriver/test/chromedriver_tests.py ...
8 years, 4 months ago (2012-08-06 22:42:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/10828135/9002
8 years, 4 months ago (2012-08-06 23:59:03 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 01:17:20 UTC) #8
Change committed as 150214

Powered by Google App Engine
This is Rietveld 408576698