Desktop Aura: Allow tab drags out of window.

chrome/browser/ui/views/tabs/tab_drag_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_TABS_TAB_DRAG_CONTROLLER_H_
 #define CHROME_BROWSER_UI_VIEWS_TABS_TAB_DRAG_CONTROLLER_H_
 
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
@@ skipping 303 matching lines @@
   void Attach(TabStrip* attached_tabstrip, const gfx::Point& point_in_screen);
 
   // Detach the dragged Tab from the current TabStrip.
   void Detach(ReleaseCapture release_capture);
 
   // Detaches the tabs being dragged, creates a new Browser to contain them and
   // runs a nested move loop.
   void DetachIntoNewBrowserAndRunMoveLoop(const gfx::Point& point_in_screen);
 
   // Runs a nested message loop that handles moving the current Browser.
-  void RunMoveLoop();
+  void RunMoveLoop(const gfx::Point& drag_offset);

[sky, 2012/08/16 20:11:20]

Document drag_offset.

 
   // Determines the index to insert tabs at. |dragged_bounds| is the bounds of
   // the tabs being dragged, |start| the index of the tab to start looking from
   // and |delta| the amount to increment (1 or -1).
   int GetInsertionIndexFrom(const gfx::Rect& dragged_bounds,
                             int start,
                             int delta) const;
 
   // Returns the index where the dragged WebContents should be inserted into
   // |attached_tabstrip_| given the DraggedTabView's bounds |dragged_bounds| in
@@ skipping 86 matching lines @@
   // Returns the Widget of the currently attached TabStrip's BrowserView.
   views::Widget* GetAttachedBrowserWidget();
 
   // Returns true if the tabs were originality one after the other in
   // |source_tabstrip_|.
   bool AreTabsConsecutive();
 
   // Creates and returns a new Browser to handle the drag.
   Browser* CreateBrowserForDrag(TabStrip* source,
                                 const gfx::Point& point_in_screen,
+                                gfx::Point* drag_offset,
                                 std::vector<gfx::Rect>* drag_bounds);
 
   // Returns the TabStripModel for the specified tabstrip.
   TabStripModel* GetModel(TabStrip* tabstrip) const;
 
   // Returns the location of the cursor. This is either the location of the
   // mouse or the location of the current touch point.
   gfx::Point GetCursorScreenPoint();
 
+  // Returns the offset from the top left corner of the window to
+  // |point_in_screen|.
+  gfx::Point GetWindowOffset(const gfx::Point& point_in_screen);
+
   // Returns true if moving the mouse only changes the visible tabs.
   bool move_only() const {
     return (move_behavior_ == MOVE_VISIBILE_TABS) != 0;
   }
 
   // If true Detaching creates a new browser and enters a nested message loop.
   const bool detach_into_browser_;
 
   // Handles registering for notifications.
   content::NotificationRegistrar registrar_;
@@ skipping 12 matching lines @@
   // operation. This is used to calculate minimum elasticity before a
   // DraggedTabView is constructed.
   gfx::Point start_point_in_screen_;
 
   // This is the offset of the mouse from the top left of the Tab where
   // dragging begun. This is used to ensure that the dragged view is always
   // positioned at the correct location during the drag, and to ensure that the
   // detached window is created at the right location.
   gfx::Point mouse_offset_;
 
+  gfx::Point window_mouse_offset_;

[sky, 2012/08/16 20:11:20]

Add description.

[Elliot Glaysher, 2012/08/16 20:33:48]

Removed stray mark. 

+
   // Offset of the mouse relative to the source tab.
   int source_tab_offset_;
 
   // Ratio of the x-coordinate of the |source_tab_offset_| to the width of the
   // tab. Not used for vertical tabs.
   float offset_to_width_ratio_;
 
   // A hint to use when positioning new windows created by detaching Tabs. This
   // is the distance of the mouse from the top left of the dragged tab as if it
   // were the distance of the mouse from the top left of the first tab in the
@@ skipping 89 matching lines @@
   // Non-null for the duration of RunMoveLoop.
   views::Widget* move_loop_widget_;
 
   // If non-null set to true from destructor.
   bool* destroyed_;
 
   DISALLOW_COPY_AND_ASSIGN(TabDragController);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_TABS_TAB_DRAG_CONTROLLER_H_