Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1809)

Unified Diff: net/spdy/spdy_session_spdy3_unittest.cc

Issue 10828129: SPDY: WriteHeaders should not invoke OnDataSent callback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add check for OnHeadersSent in tests Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_session_spdy3_unittest.cc
diff --git a/net/spdy/spdy_session_spdy3_unittest.cc b/net/spdy/spdy_session_spdy3_unittest.cc
index ae4d54ea9483f59a601c1430030a3b60cadc4e36..02f5f78afece9bd87d07f7d8cb4d8f608ec8c545 100644
--- a/net/spdy/spdy_session_spdy3_unittest.cc
+++ b/net/spdy/spdy_session_spdy3_unittest.cc
@@ -43,6 +43,7 @@ class ClosingDelegate : public SpdyStream::Delegate {
int status) OVERRIDE {
return OK;
}
+ virtual void OnHeadersSent() OVERRIDE {}
virtual void OnDataReceived(const char* data, int length) OVERRIDE {}
virtual void OnDataSent(int length) OVERRIDE {}
virtual void OnClose(int status) OVERRIDE {
@@ -53,35 +54,35 @@ class ClosingDelegate : public SpdyStream::Delegate {
};
-class TestSpdyStreamDelegate : public net::SpdyStream::Delegate {
+class TestSpdyStreamDelegate : public SpdyStream::Delegate {
public:
explicit TestSpdyStreamDelegate(const CompletionCallback& callback)
: callback_(callback) {}
virtual ~TestSpdyStreamDelegate() {}
- virtual bool OnSendHeadersComplete(int status) { return true; }
+ virtual bool OnSendHeadersComplete(int status) OVERRIDE { return true; }
- virtual int OnSendBody() {
+ virtual int OnSendBody() OVERRIDE {
return ERR_UNEXPECTED;
}
- virtual int OnSendBodyComplete(int /*status*/, bool* /*eof*/) {
+ virtual int OnSendBodyComplete(int /*status*/, bool* /*eof*/) OVERRIDE {
return ERR_UNEXPECTED;
}
virtual int OnResponseReceived(const SpdyHeaderBlock& response,
base::Time response_time,
- int status) {
+ int status) OVERRIDE {
return status;
}
- virtual void OnDataReceived(const char* buffer, int bytes) {
- }
+ virtual void OnHeadersSent() OVERRIDE {}
- virtual void OnDataSent(int length) {
- }
+ virtual void OnDataReceived(const char* buffer, int bytes) OVERRIDE {}
- virtual void OnClose(int status) {
+ virtual void OnDataSent(int length) OVERRIDE {}
+
+ virtual void OnClose(int status) OVERRIDE {
CompletionCallback callback = callback_;
callback_.Reset();
callback.Run(OK);

Powered by Google App Engine
This is Rietveld 408576698