Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: net/spdy/spdy_stream_spdy2_unittest.cc

Issue 10828129: SPDY: WriteHeaders should not invoke OnDataSent callback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_stream.cc ('k') | net/spdy/spdy_stream_spdy3_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_stream_spdy2_unittest.cc
diff --git a/net/spdy/spdy_stream_spdy2_unittest.cc b/net/spdy/spdy_stream_spdy2_unittest.cc
index 8055fd835fcf868e34e3c3ce049d2325f295ca1e..37bc3920e76874b4301952aa914a6a5f5854cf2e 100644
--- a/net/spdy/spdy_stream_spdy2_unittest.cc
+++ b/net/spdy/spdy_stream_spdy2_unittest.cc
@@ -266,10 +266,9 @@ TEST_F(SpdyStreamSpdy2Test, SendHeaderAndDataAfterOpen) {
EXPECT_TRUE(delegate->send_headers_completed());
EXPECT_EQ("101", (*delegate->response())["status"]);
+ EXPECT_EQ(1, delegate->headers_sent());
EXPECT_EQ(std::string(), delegate->received_data());
- // TODO(toyoshim): OnDataSent should be invoked when each data frame is sent.
- // But current implementation invokes also when each HEADERS frame is sent.
- //EXPECT_EQ(6, delegate->data_sent());
+ EXPECT_EQ(6, delegate->data_sent());
}
TEST_F(SpdyStreamSpdy2Test, PushedStream) {
« no previous file with comments | « net/spdy/spdy_stream.cc ('k') | net/spdy/spdy_stream_spdy3_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698