SPDY: WriteHeaders should not invoke OnDataSent callback

net/spdy/spdy_session_spdy2_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_session.h"
 
 #include "net/base/host_cache.h"
 #include "net/base/ip_endpoint.h"
 #include "net/base/net_log_unittest.h"
 #include "net/spdy/spdy_io_buffer.h"
@@ skipping 25 matching lines @@
     return OK;
   }
   virtual int OnSendBodyComplete(int status, bool* eof) OVERRIDE {
     return OK;
   }
   virtual int OnResponseReceived(const SpdyHeaderBlock& response,
                                  base::Time response_time,
                                  int status) OVERRIDE {
     return OK;
   }
+  virtual void OnHeadersSent() OVERRIDE {}
   virtual void OnDataReceived(const char* data, int length) OVERRIDE {}
   virtual void OnDataSent(int length) OVERRIDE {}
   virtual void OnClose(int status) OVERRIDE {
     stream_->Close();
   }
  private:
   SpdyStream* stream_;
 };
 
 } // namespace
 
 // TODO(cbentzel): Expose compression setter/getter in public SpdySession
 //                 interface rather than going through all these contortions.
 class SpdySessionSpdy2Test : public PlatformTest {
  protected:
   virtual void SetUp() {
     SpdySession::set_default_protocol(kProtoSPDY2);
   }
 
  private:
   SpdyTestStateHelper spdy_state_;
 };
 
 class TestSpdyStreamDelegate : public net::SpdyStream::Delegate {
  public:
   explicit TestSpdyStreamDelegate(const CompletionCallback& callback)
       : callback_(callback) {}
   virtual ~TestSpdyStreamDelegate() {}
 
-  virtual bool OnSendHeadersComplete(int status) { return true; }
+  virtual bool OnSendHeadersComplete(int status) OVERRIDE { return true; }
 
-  virtual int OnSendBody() {
+  virtual int OnSendBody() OVERRIDE {
     return ERR_UNEXPECTED;
   }
 
-  virtual int OnSendBodyComplete(int /*status*/, bool* /*eof*/) {
+  virtual int OnSendBodyComplete(int /*status*/, bool* /*eof*/) OVERRIDE {
     return ERR_UNEXPECTED;
   }
 
   virtual int OnResponseReceived(const SpdyHeaderBlock& response,
                                  base::Time response_time,
-                                 int status) {
+                                 int status) OVERRIDE {
     return status;
   }
 
-  virtual void OnDataReceived(const char* buffer, int bytes) {
-  }
+  virtual void OnHeadersSent() OVERRIDE {}
+  virtual void OnDataReceived(const char* buffer, int bytes) OVERRIDE {}
 
-  virtual void OnDataSent(int length) {
-  }
+  virtual void OnDataSent(int length) OVERRIDE {}
 
-  virtual void OnClose(int status) {
+  virtual void OnClose(int status) OVERRIDE {
     CompletionCallback callback = callback_;
     callback_.Reset();
     callback.Run(OK);
   }
 
  private:
   CompletionCallback callback_;
 };
 
 // Test the SpdyIOBuffer class.
@@ skipping 1403 matching lines @@
   session->CloseSessionOnError(ERR_ABORTED, true, "");
 
   EXPECT_TRUE(spdy_stream1->closed());
   EXPECT_TRUE(spdy_stream2->closed());
 
   spdy_stream1 = NULL;
   spdy_stream2 = NULL;
 }
 
 }  // namespace net