Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1631)

Side by Side Diff: net/spdy/spdy_http_stream.h

Issue 10828129: SPDY: WriteHeaders should not invoke OnDataSent callback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | net/spdy/spdy_http_stream.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_SPDY_SPDY_HTTP_STREAM_H_ 5 #ifndef NET_SPDY_SPDY_HTTP_STREAM_H_
6 #define NET_SPDY_SPDY_HTTP_STREAM_H_ 6 #define NET_SPDY_SPDY_HTTP_STREAM_H_
7 7
8 #include <list> 8 #include <list>
9 #include <string> 9 #include <string>
10 10
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 virtual void LogNumRttVsBytesMetrics() const OVERRIDE {} 74 virtual void LogNumRttVsBytesMetrics() const OVERRIDE {}
75 virtual void Drain(HttpNetworkSession* session) OVERRIDE; 75 virtual void Drain(HttpNetworkSession* session) OVERRIDE;
76 76
77 // SpdyStream::Delegate implementation. 77 // SpdyStream::Delegate implementation.
78 virtual bool OnSendHeadersComplete(int status) OVERRIDE; 78 virtual bool OnSendHeadersComplete(int status) OVERRIDE;
79 virtual int OnSendBody() OVERRIDE; 79 virtual int OnSendBody() OVERRIDE;
80 virtual int OnSendBodyComplete(int status, bool* eof) OVERRIDE; 80 virtual int OnSendBodyComplete(int status, bool* eof) OVERRIDE;
81 virtual int OnResponseReceived(const SpdyHeaderBlock& response, 81 virtual int OnResponseReceived(const SpdyHeaderBlock& response,
82 base::Time response_time, 82 base::Time response_time,
83 int status) OVERRIDE; 83 int status) OVERRIDE;
84 virtual void OnHeadersSent() OVERRIDE;
84 virtual int OnDataReceived(const char* buffer, int bytes) OVERRIDE; 85 virtual int OnDataReceived(const char* buffer, int bytes) OVERRIDE;
85 virtual void OnDataSent(int length) OVERRIDE; 86 virtual void OnDataSent(int length) OVERRIDE;
86 virtual void OnClose(int status) OVERRIDE; 87 virtual void OnClose(int status) OVERRIDE;
87 88
88 // ChunkCallback implementation. 89 // ChunkCallback implementation.
89 virtual void OnChunkAvailable() OVERRIDE; 90 virtual void OnChunkAvailable() OVERRIDE;
90 91
91 private: 92 private:
92 FRIEND_TEST_ALL_PREFIXES(SpdyNetworkTransactionSpdy2Test, 93 FRIEND_TEST_ALL_PREFIXES(SpdyNetworkTransactionSpdy2Test,
93 FlowControlStallResume); 94 FlowControlStallResume);
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 bool waiting_for_chunk_; 159 bool waiting_for_chunk_;
159 160
160 bool send_last_chunk_; 161 bool send_last_chunk_;
161 162
162 DISALLOW_COPY_AND_ASSIGN(SpdyHttpStream); 163 DISALLOW_COPY_AND_ASSIGN(SpdyHttpStream);
163 }; 164 };
164 165
165 } // namespace net 166 } // namespace net
166 167
167 #endif // NET_SPDY_SPDY_HTTP_STREAM_H_ 168 #endif // NET_SPDY_SPDY_HTTP_STREAM_H_
OLDNEW
« no previous file with comments | « no previous file | net/spdy/spdy_http_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698