Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: chrome/renderer/chrome_render_view_observer.h

Issue 10828127: Use hi-resolution favicon variants if available. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: daringfireball hackfix Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/chrome_render_view_observer.h
diff --git a/chrome/renderer/chrome_render_view_observer.h b/chrome/renderer/chrome_render_view_observer.h
index 8691ad21d32027473180c70b33e95bbeadc877e6..b3b9bccbc5cfc30e143dce040051db2201976952 100644
--- a/chrome/renderer/chrome_render_view_observer.h
+++ b/chrome/renderer/chrome_render_view_observer.h
@@ -35,7 +35,7 @@ class PhishingClassifierDelegate;
}
namespace webkit_glue {
-class ImageResourceFetcher;
+class MultiResolutionImageResourceFetcher;
}
// This class holds the Chrome specific parts of RenderView, and has the same
@@ -130,7 +130,7 @@ class ChromeRenderViewObserver : public content::RenderViewObserver,
const std::string& origin,
const std::string& target);
void OnJavaScriptStressTestControl(int cmd, int param);
- void OnDownloadFavicon(int id, const GURL& image_url, int image_size);
+ void OnDownloadFavicon(int id, const GURL& image_url, const std::vector<int>& image_size);
void OnSetIsPrerendering(bool is_prerendering);
void OnSetAllowDisplayingInsecureContent(bool allow);
void OnSetAllowRunningInsecureContent(bool allow);
@@ -167,8 +167,9 @@ class ChromeRenderViewObserver : public content::RenderViewObserver,
// This callback is triggered when DownloadFavicon completes, either
// succesfully or with a failure. See DownloadFavicon for more
// details.
- void DidDownloadFavicon(webkit_glue::ImageResourceFetcher* fetcher,
- const SkBitmap& image);
+ void DidDownloadFavicon(
+ webkit_glue::MultiResolutionImageResourceFetcher* fetcher,
+ const std::vector<SkBitmap>& images);
// Requests to download a favicon image. When done, the RenderView
// is notified by way of DidDownloadFavicon. Returns true if the
@@ -177,7 +178,7 @@ class ChromeRenderViewObserver : public content::RenderViewObserver,
// DidDownloadFavicon method. If the image has multiple frames, the
// frame whose size is image_size is returned. If the image doesn't
// have a frame at the specified size, the first is returned.
- bool DownloadFavicon(int id, const GURL& image_url, int image_size);
+ bool DownloadFavicon(int id, const GURL& image_url, const std::vector<int>& image_size);
// Decodes a data: URL image or returns an empty image in case of failure.
SkBitmap ImageFromDataUrl(const GURL&) const;
@@ -218,7 +219,7 @@ class ChromeRenderViewObserver : public content::RenderViewObserver,
// External host exposed through automation controller.
scoped_ptr<ExternalHostBindings> external_host_bindings_;
- typedef std::vector<linked_ptr<webkit_glue::ImageResourceFetcher> >
+ typedef std::vector<linked_ptr<webkit_glue::MultiResolutionImageResourceFetcher> >
ImageResourceFetcherList;
// ImageResourceFetchers schedule via DownloadImage.

Powered by Google App Engine
This is Rietveld 408576698