chrome/browser/ui/views/ash/launcher/launcher_favicon_loader.cc - Issue 10828127: Use hi-resolution favicon variants if available.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/ash/launcher/launcher_favicon_loader.cc

Issue 10828127: Use hi-resolution favicon variants if available. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: daringfireball hackfix Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/ash/launcher/launcher_favicon_loader.cc

diff --git a/chrome/browser/ui/views/ash/launcher/launcher_favicon_loader.cc b/chrome/browser/ui/views/ash/launcher/launcher_favicon_loader.cc

index 33a08df67b54f38f6813e8be753650c4cbc6e8d4..8ff3f9ae0a996eec2b6be90e2c4c2f68c74ce51b 100644

--- a/chrome/browser/ui/views/ash/launcher/launcher_favicon_loader.cc

+++ b/chrome/browser/ui/views/ash/launcher/launcher_favicon_loader.cc

@@ -109,7 +109,7 @@ void FaviconBitmapHandler::DownloadFavicon(const GURL& image_url) {

int image_size = 0; // Request the full sized image.

pending_requests_.insert(image_url);

content::RenderViewHost* host = web_contents_->GetRenderViewHost();

- FaviconUtil::DownloadFavicon(host, image_url, image_size);

+ FaviconUtil::DownloadFavicon(host, image_url, std::vector<int>(1, image_size)); // XXX

}

void FaviconBitmapHandler::OnDidDownloadFavicon(int id,