Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1491)

Unified Diff: chrome/browser/favicon/favicon_tab_helper.h

Issue 10828127: Use hi-resolution favicon variants if available. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: daringfireball hackfix Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/favicon/favicon_tab_helper.h
diff --git a/chrome/browser/favicon/favicon_tab_helper.h b/chrome/browser/favicon/favicon_tab_helper.h
index caa54170a8788709d04374f45c2e1e5e21a0616d..3d6be79792056bc86aca3769c191abb4e72a13b8 100644
--- a/chrome/browser/favicon/favicon_tab_helper.h
+++ b/chrome/browser/favicon/favicon_tab_helper.h
@@ -15,6 +15,10 @@
#include "content/public/browser/web_contents_observer.h"
#include "googleurl/src/gurl.h"
+namespace gfx {
+class Image;
+}
+
class FaviconHandler;
class SkBitmap;
@@ -42,6 +46,8 @@ class FaviconTabHelper : public content::WebContentsObserver,
// entries, which should rarely happen.
SkBitmap GetFavicon() const;
+ gfx::Image GetFaviconImage() const;
+
// Returns true if we have the favicon for the page.
bool FaviconIsValid() const;
@@ -73,7 +79,7 @@ class FaviconTabHelper : public content::WebContentsObserver,
// FaviconHandlerDelegate methods.
virtual content::NavigationEntry* GetActiveEntry() OVERRIDE;
- virtual int StartDownload(const GURL& url, int image_size) OVERRIDE;
+ virtual int StartDownload(const GURL& url, const std::vector<int>& image_size) OVERRIDE;
virtual void NotifyFaviconUpdated() OVERRIDE;
private:
@@ -89,7 +95,7 @@ class FaviconTabHelper : public content::WebContentsObserver,
void OnDidDownloadFavicon(int id,
const GURL& image_url,
bool errored,
- const SkBitmap& image);
+ const std::vector<SkBitmap>& image);
Profile* profile_;

Powered by Google App Engine
This is Rietveld 408576698