Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 10828126: gdata: Introduce GDataWapiFeedLoader class (Closed)

Created:
8 years, 4 months ago by satorux1
Modified:
8 years, 4 months ago
Reviewers:
achuithb
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

gdata: Introduce GDataWapiFeedLoader class This class is introduced to separate code related to WAPI (codename of Documents List API) feed loading. To minimize diffs, the the class is defined in gdata_file_system.cc The code will be moved to a set of new files in a separate patch. BUG=130669 TEST=out/Release/unit_tests --gtest_filter=GData* && out/Release/browser_tests --gtest_filter=GData* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149591

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase and fix #

Patch Set 3 : rebase and fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+374 lines, -202 lines) Patch
M chrome/browser/chromeos/gdata/gdata_file_system.h View 1 2 10 chunks +170 lines, -91 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system.cc View 1 2 34 chunks +191 lines, -110 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/gdata_files.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_files.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
satorux1
Here's another one.
8 years, 4 months ago (2012-08-02 00:55:43 UTC) #1
achuithb
Ya, I do like it. It's going to make my rebase difficult though :/ lgtm ...
8 years, 4 months ago (2012-08-02 01:38:25 UTC) #2
satorux1
8 years, 4 months ago (2012-08-02 07:22:51 UTC) #3
http://codereview.chromium.org/10828126/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/10828126/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.cc:801:
weak_ptr_factory_.GetWeakPtr(),
On 2012/08/02 01:38:25, achuith.bhandarkar wrote:
> why not ui_weak_ptr_ here?

Changed back to ui_weak_ptr_. I tried to delete ui_weak_ptr_ in a separate
patch, but was a bad idea.

http://codereview.chromium.org/10828126/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.cc:976: local_changestamp + 1,
0,
On 2012/08/02 01:38:25, achuith.bhandarkar wrote:
> nit: indentation

Done.

Powered by Google App Engine
This is Rietveld 408576698