Issue 10828119: Reorder declaration vs. usage, build padToWidth on top of stringOfLength.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10828119: Reorder declaration vs. usage, build padToWidth on top of stringOfLength. (Closed)

Created:
8 years, 4 months ago by ericu

Modified:
8 years, 4 months ago

Reviewers:
dgrogan, alecflett

CC:
chromium-reviews, dgrogan, jsbell

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Reorder declaration vs. usage, build padToWidth on top of stringOfLength. All changes in perf_test.js are reorders--no actual code change. BUG=137764 TEST=self Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149477

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+139 lines, -136 lines)			Patch
	M	chrome/test/data/indexeddb/perf_shared.js	View		2 chunks	+10 lines, -9 lines	0 comments	Download
	M	chrome/test/data/indexeddb/perf_test.js	View		12 chunks	+129 lines, -127 lines	0 comments	Download

Total messages: 2 (0 generated)

ericu

I'm clearly outnumbered on the code order issue, so here's the fixup.

8 years, 4 months ago (2012-08-01 18:58:12 UTC) #1

lgtm