Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 10828114: Fix missing default values. (Closed)

Created:
8 years, 4 months ago by Seigo Nonaka
Modified:
8 years, 4 months ago
Reviewers:
satorux1
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@ibus_module_revise
Visibility:
Public.

Description

Fix missing default values. In IBusLookupTable::page_size actually does not affect for Chrome OS. However, if we use chromeos-chrome on linux desktop, zero value crashes ibus's lookup table. BUG=None TEST=ran chromeos_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149580

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add default value for initial page size constant #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chromeos/dbus/ibus/ibus_lookup_table.cc View 1 2 chunks +6 lines, -1 line 0 comments Download
M chromeos/dbus/ibus/ibus_property.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Seigo Nonaka
8 years, 4 months ago (2012-08-01 13:33:02 UTC) #1
satorux1
LGTM with a nit http://codereview.chromium.org/10828114/diff/1/chromeos/dbus/ibus/ibus_lookup_table.cc File chromeos/dbus/ibus/ibus_lookup_table.cc (right): http://codereview.chromium.org/10828114/diff/1/chromeos/dbus/ibus/ibus_lookup_table.cc#newcode200 chromeos/dbus/ibus/ibus_lookup_table.cc:200: : page_size_(9), please add some ...
8 years, 4 months ago (2012-08-01 19:56:02 UTC) #2
Seigo Nonaka
http://codereview.chromium.org/10828114/diff/1/chromeos/dbus/ibus/ibus_lookup_table.cc File chromeos/dbus/ibus/ibus_lookup_table.cc (right): http://codereview.chromium.org/10828114/diff/1/chromeos/dbus/ibus/ibus_lookup_table.cc#newcode200 chromeos/dbus/ibus/ibus_lookup_table.cc:200: : page_size_(9), On 2012/08/01 19:56:02, satorux1 wrote: > please ...
8 years, 4 months ago (2012-08-02 04:03:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/10828114/5001
8 years, 4 months ago (2012-08-02 04:08:44 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 05:52:28 UTC) #5
Change committed as 149580

Powered by Google App Engine
This is Rietveld 408576698