When specifying a new create histogram callback, reset all histograms so they recreate themselves o…

src/api.cc

Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index d439472536cdb019fe8fc1b7c4413f114c7893bf..049f790c1429ec5f23869af622299664f85608d5 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -5223,6 +5223,7 @@ void V8::SetCreateHistogramFunction(CreateHistogramCallback callback) {
   i::Isolate* isolate = EnterIsolateIfNeeded();
   if (IsDeadCheck(isolate, "v8::V8::SetCreateHistogramFunction()")) return;
   isolate->stats_table()->SetCreateHistogramFunction(callback);
+  if (isolate->IsInitialized()) isolate->counters()->ResetHistograms();

[Michael Starzinger, 2012/08/01 12:45:30]

I am not sure about this. There might be some weird case where the isolate
wasn't initialized but the counters have already been setup. It just feels
fragile.

Can we instead just call InitializeLoggingAndCounters() before resetting the
histograms (assuming that if someone calls SetCreateHistogramFunction on this
isolate he will actually initialize this isolate soonish)?

[jochen (gone - plz use gerrit), 2012/08/01 12:47:41]

Done.

 }
 
 void V8::SetAddHistogramSampleFunction(AddHistogramSampleCallback callback) {